Extend argument validation in `splitByString` tokenizer by rschu1ze · Pull Request #101928 · ClickHouse/ClickHouse · GitHub
Skip to content

Extend argument validation in splitByString tokenizer#101928

Merged
rschu1ze merged 3 commits into
masterfrom
splitByString-validation
Apr 8, 2026
Merged

Extend argument validation in splitByString tokenizer#101928
rschu1ze merged 3 commits into
masterfrom
splitByString-validation

Conversation

@rschu1ze

@rschu1ze rschu1ze commented Apr 7, 2026

Copy link
Copy Markdown
Member

Resolves #101923

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

The splitByString tokenizer now rejects empty separator strings.

Version info

  • Merged into: 26.4.1.660
  • Backported to: 26.3.5.10, 26.2.9.9

@clickhouse-gh

clickhouse-gh Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

@clickhouse-gh clickhouse-gh Bot added the pr-bugfix Pull request with bugfix, not backported by default label Apr 7, 2026
@rschu1ze rschu1ze changed the title Add missing argument validation for splitByString tokenizer Extend argument validation in splitByString tokenizer Apr 7, 2026
alexey-milovidov added a commit that referenced this pull request Apr 7, 2026
…eck`

These tests enumerate all functions with bad arguments and are too slow
to run repeatedly in the flaky check (which now combines the old targeted
and flaky checks into a single job with up to 50-100 repeats).

#101928

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alexey-milovidov

Copy link
Copy Markdown
Member

The failures of "Flaky check" in "functions_bad_arguments" will be fixed by #101994.

@clickhouse-gh

clickhouse-gh Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

LLVM Coverage Report

Metric Baseline Current Δ
Lines 84.00% 83.90% -0.10%
Functions 90.90% 90.90% +0.00%
Branches 76.50% 76.40% -0.10%

Changed lines: 100.00% (18/18) | lost baseline coverage: 1 line(s) · Uncovered code

Full report · Diff report

@rschu1ze rschu1ze added this pull request to the merge queue Apr 8, 2026
@rschu1ze rschu1ze added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Apr 8, 2026
Merged via the queue into master with commit ac7a313 Apr 8, 2026
163 checks passed
@rschu1ze rschu1ze deleted the splitByString-validation branch April 8, 2026 15:28
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Apr 8, 2026
robot-clickhouse added a commit that referenced this pull request Apr 8, 2026
robot-clickhouse added a commit that referenced this pull request Apr 8, 2026
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 8, 2026
clickhouse-gh Bot added a commit that referenced this pull request Apr 8, 2026
Backport #101928 to 26.3: Extend argument validation in `splitByString` tokenizer
clickhouse-gh Bot added a commit that referenced this pull request Apr 8, 2026
Backport #101928 to 26.2: Extend argument validation in `splitByString` tokenizer
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty string separator in splitByString tokenizer causes infinite loop (server hang)

6 participants