Fix using wrong extreams in min-max index created on JSON column by Avogar · Pull Request #101918 · ClickHouse/ClickHouse · GitHub
Skip to content

Fix using wrong extreams in min-max index created on JSON column#101918

Merged
Avogar merged 3 commits into
masterfrom
fix-json-in-min-max-index
Apr 17, 2026
Merged

Fix using wrong extreams in min-max index created on JSON column#101918
Avogar merged 3 commits into
masterfrom
fix-json-in-min-max-index

Conversation

@Avogar

@Avogar Avogar commented Apr 7, 2026 •
edited by robot-clickhouse
Loading

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix using wrong extreams in min-max index created on JSON column leading to wrong query result. Closes #101700.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Version info

  • Merged into: 26.4.1.1025
  • Backported to: 26.3.10.20, 26.2.17.9, 26.1.12.7, 25.8.23.9

@clickhouse-gh

clickhouse-gh Bot commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@clickhouse-gh clickhouse-gh Bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Apr 7, 2026
@Avogar Avogar mentioned this pull request Apr 7, 2026
Closed
1 task
@evillique evillique self-assigned this Apr 9, 2026
@alexey-milovidov

alexey-milovidov commented Apr 10, 2026

Copy link
Copy Markdown
Member

The flaky check failure is fixed in #102148, let's update the branch.

clickhouse-gh[bot]
clickhouse-gh Bot reviewed Apr 16, 2026
View reviewed changes
Comment thread tests/queries/0_stateless/04076_json_in_min_max_index_bug.sql
@@ -0,0 +1,21 @@
-- Tags: no-parallel-replicas
-- Tag no-parallel-replicas: output of explain is different

@clickhouse-gh clickhouse-gh Bot Apr 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the test note: Tag should be Tags to match the standard header format (-- Tags: ...). Also consider uppercasing EXPLAIN for consistency with SQL keywords.

@clickhouse-gh

clickhouse-gh Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

LLVM Coverage Report

Metric Baseline Current Δ
Lines 84.10% 84.00% -0.10%
Functions 90.90% 90.90% +0.00%
Branches 76.60% 76.50% -0.10%

Changed lines: 57.14% (8/14) · Uncovered code

Full report · Diff report

@Avogar Avogar added this pull request to the merge queue Apr 17, 2026
Merged via the queue into master with commit 2be6053 Apr 17, 2026
161 checks passed
@Avogar Avogar deleted the fix-json-in-min-max-index branch April 17, 2026 13:19
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 17, 2026
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Apr 17, 2026
This was referenced Apr 17, 2026
Merged
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Apr 17, 2026
@robot-clickhouse-ci-2
Merge pull request #103010 from ClickHouse/cherrypick/26.2/101918
aa562e6 
Cherry pick #101918 to 26.2: Fix using wrong extreams in min-max index created on JSON column
robot-clickhouse added a commit that referenced this pull request Apr 17, 2026
@robot-clickhouse
Backport #101918 to 26.2: Fix using wrong extreams in min-max index c…
561b81c 
…reated on JSON column
This was referenced Apr 17, 2026
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Apr 17, 2026
@robot-clickhouse-ci-2
Merge pull request #103012 from ClickHouse/cherrypick/26.3/101918
0809b2b 
Cherry pick #101918 to 26.3: Fix using wrong extreams in min-max index created on JSON column
robot-clickhouse added a commit that referenced this pull request Apr 17, 2026
@robot-clickhouse
Backport #101918 to 26.3: Fix using wrong extreams in min-max index c…
b65babe 
…reated on JSON column
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Apr 17, 2026
Merged
clickhouse-gh Bot added a commit that referenced this pull request Apr 17, 2026
@clickhouse-gh
Merge pull request #103011 from ClickHouse/backport/26.2/101918
ec64b3c 
Backport #101918 to 26.2: Fix using wrong extreams in min-max index created on JSON column
Avogar added a commit that referenced this pull request Apr 20, 2026
@Avogar
Merge pull request #103013 from ClickHouse/backport/26.3/101918
30a4a04 
Backport #101918 to 26.3: Fix using wrong extreams in min-max index created on JSON column
robot-clickhouse-ci-1 added a commit that referenced this pull request Apr 20, 2026
@robot-clickhouse-ci-1
Merge pull request #103008 from ClickHouse/cherrypick/25.8/101918
eb58c9c 
Cherry pick #101918 to 25.8: Fix using wrong extreams in min-max index created on JSON column
robot-clickhouse added a commit that referenced this pull request Apr 20, 2026
@robot-clickhouse
Backport #101918 to 25.8: Fix using wrong extreams in min-max index c…
bb6aa71 
…reated on JSON column
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Apr 20, 2026
Merged
robot-clickhouse-ci-1 added a commit that referenced this pull request Apr 20, 2026
@robot-clickhouse-ci-1
Merge pull request #103009 from ClickHouse/cherrypick/26.1/101918
a604512 
Cherry pick #101918 to 26.1: Fix using wrong extreams in min-max index created on JSON column
robot-clickhouse added a commit that referenced this pull request Apr 20, 2026
@robot-clickhouse
Backport #101918 to 26.1: Fix using wrong extreams in min-max index c…
87b27fd 
…reated on JSON column
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Apr 20, 2026
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Apr 20, 2026
clickhouse-gh Bot added a commit that referenced this pull request Apr 20, 2026
@clickhouse-gh
Merge pull request #103185 from ClickHouse/backport/26.1/101918
8f9d7eb 
Backport #101918 to 26.1: Fix using wrong extreams in min-max index created on JSON column
Avogar added a commit that referenced this pull request Apr 23, 2026
@Avogar
Merge pull request #103184 from ClickHouse/backport/25.8/101918
d4be641 
Backport #101918 to 25.8: Fix using wrong extreams in min-max index created on JSON column
@groeneai groeneai mentioned this pull request May 16, 2026
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Jun 27, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clickhouse-gh clickhouse-gh[bot] clickhouse-gh[bot] left review comments
@evillique evillique evillique approved these changes

Assignees

@evillique evillique

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MinMax index on JSON column silently drops valid rows due to missing isObject() check in validator and broken getExtremes()

6 participants

@Avogar @alexey-milovidov @evillique @robot-ch-test-poll @robot-ch-test-poll3 @robot-clickhouse-ci-1