{{ message }}
Fix flaky test_backup_to_s3_different_credentials#101897
Closed
alexey-milovidov wants to merge 3 commits into
Closed
Fix flaky test_backup_to_s3_different_credentials#101897alexey-milovidov wants to merge 3 commits into
alexey-milovidov wants to merge 3 commits into
Conversation
When `allow_s3_native_copy=True` with different credentials, the native S3 copy fails and falls back to reading+writing. During this fallback, transient `S3ReadRequestsErrors` are possible (similar to how `S3WriteRequestsErrors` are already tolerated for multipart uploads). Relax the assertion to only check for read errors when native copy is not enabled. Fixes #90662 https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=101239&sha=4f2e44e494b3285afa9dc9d659bc7e05b440337b&name_0=PR&name_1=Integration%20tests%20%28amd_asan_ubsan%2C%20db%20disk%2C%20old%20analyzer%2C%202%2F6%29 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
allow_s3_native_copy=Truewith different credentials, the native S3 copy fails and falls back to reading+writing. During this fallback, transientS3ReadRequestsErrorsare possible (similar to howS3WriteRequestsErrorsare already tolerated for multipart uploads on lines 999-1003). Relax the assertion to only check for read errors when native copy is not enabled.Fixes #90662
https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=101239&sha=4f2e44e494b3285afa9dc9d659bc7e05b440337b&name_0=PR&name_1=Integration%20tests%20%28amd_asan_ubsan%2C%20db%20disk%2C%20old%20analyzer%2C%202%2F6%29
#101239
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes