{{ message }}
Add test with virtual columns pruning for delta lake#101634
Merged
scanhex12 merged 1 commit intoApr 2, 2026
Merged
Conversation
Contributor
clickhouse-gh
Bot
added
pr-improvement
![clickhouse-gh[bot]](https://avatars.githubusercontent.com/in/928874?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Using Context::getGlobalContextInstance() here is unsafe for query-scoped predicates. This path calls buildSetsForDAG and later evaluates filterByPathOrFile; if _path/_file predicate contains subqueries (e.g. IN (SELECT ...)) or depends on session settings, evaluating with global context can change semantics and ignore per-query context/security/settings.
Please pass and store the query ContextPtr in TableSnapshot::Iterator, and use it consistently in createPathAndFileFilterDAG, buildSetsForDAG, and filterByPathOrFile.
scanhex12
force-pushed
the
delta_lake_virtual_columns_pruner
branch
from
25b1629 to
c773ea3
Compare
scanhex12
changed the title
kssenii
approved these changes
Apr 2, 2026
robot-ch-test-poll3
added
the
pr-synced-to-cloud
alexey-milovidov
added a commit
that referenced
this pull request
Apr 30, 2026
- Replace TODO authoring notes with user-facing summaries (or drop entries that are not user-visible). - Drop changelog item for `#101634` since the PR only adds a test. - Drop changelog item for `#100315` since the PR only adds an internal `getLastWrittenObjectPath` method on `ObjectStorage`. - Rewrite the duplicated "This PR addresses several issues..." entry for `#99163` / `#100420` as a single coherent sentence. - Fix the `chdig` link target: the text said `v26.4.3` but the URL pointed to the `v26.4.1` tag. Both versions exist; the PR title is "Bump chdig to v26.4.3", so align the URL with the version. PR: #103729
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Delta lake pruner with virtual columns. This closes #101515
Documentation entry for user-facing changes
Version info
26.4.1.546