Fix data race on storage_id in IStorage::getDependentViewsByColumn by evillique · Pull Request #101385 · ClickHouse/ClickHouse · GitHub
Skip to content

Fix data race on storage_id in IStorage::getDependentViewsByColumn#101385

Merged
evillique merged 7 commits into
ClickHouse:masterfrom
evillique:fix-tsan-storage-id
Apr 13, 2026
Merged

Fix data race on storage_id in IStorage::getDependentViewsByColumn#101385
evillique merged 7 commits into
ClickHouse:masterfrom
evillique:fix-tsan-storage-id

Conversation

@evillique

@evillique evillique commented Mar 31, 2026

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix data race on storage_id in IStorage::getDependentViewsByColumn.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Version info

  • Merged into: 26.4.1.867
  • Backported to: 26.3.9.5, 26.2.14.2, 26.1.9.3

@clickhouse-gh

clickhouse-gh Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

@clickhouse-gh clickhouse-gh Bot added the pr-bugfix Pull request with bugfix, not backported by default label Mar 31, 2026
@thevar1able thevar1able self-assigned this Mar 31, 2026
@alexey-milovidov

Copy link
Copy Markdown
Member

The Stress test (arm_msan) failure is fixed by #101239, which should be merged first. After it is merged, please update the branch to include the fix.

@alexey-milovidov

Copy link
Copy Markdown
Member

The test 02859_replicated_db_name_zookeeper is fixed in #101952

@alexey-milovidov

Copy link
Copy Markdown
Member

The MSan stress test failure (MemorySanitizer: use-of-uninitialized-value, STID 4179-5154 or 4148-3044) is a known pre-existing issue unrelated to this PR. Fix: #102158

@alexey-milovidov

Copy link
Copy Markdown
Member

The flaky check failure is fixed in #102148, let's update the branch.

@evillique

Copy link
Copy Markdown
Member Author

@evillique evillique added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Apr 10, 2026
@clickhouse-gh

clickhouse-gh Bot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

LLVM Coverage Report

Metric Baseline Current Δ
Lines 84.10% 84.10% +0.00%
Functions 90.90% 90.90% +0.00%
Branches 76.60% 76.70% +0.10%

Changed lines: 100.00% (15/15) | lost baseline coverage: 1 line(s) · Uncovered code

Full report · Diff report

@evillique evillique added this pull request to the merge queue Apr 13, 2026
Merged via the queue into ClickHouse:master with commit 4ef6423 Apr 13, 2026
321 of 324 checks passed
@evillique evillique deleted the fix-tsan-storage-id branch April 13, 2026 10:31
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Apr 13, 2026
robot-clickhouse added a commit that referenced this pull request Apr 13, 2026
robot-clickhouse added a commit that referenced this pull request Apr 13, 2026
robot-clickhouse added a commit that referenced this pull request Apr 13, 2026
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 13, 2026
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Apr 13, 2026
clickhouse-gh Bot added a commit that referenced this pull request Apr 13, 2026
Backport #101385 to 26.1: Fix data race on storage_id in IStorage::getDependentViewsByColumn
clickhouse-gh Bot added a commit that referenced this pull request Apr 13, 2026
Backport #101385 to 26.2: Fix data race on storage_id in IStorage::getDependentViewsByColumn
clickhouse-gh Bot added a commit that referenced this pull request Apr 13, 2026
Backport #101385 to 26.3: Fix data race on storage_id in IStorage::getDependentViewsByColumn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants