{{ message }}
Fix assertTypeEquality to check both sides for wrapper column types#101105
Merged
alexey-milovidov merged 20 commits intoMay 1, 2026
Conversation
The assertion in `IColumn::assertTypeEquality` only checked if `this` was a Const/Sparse/Replicated wrapper column, but not `rhs`. When `rhs` is a wrapper column but `this` is a regular column, the assertion incorrectly required `typeid` equality, which fails even though the operation is valid. This caused a spurious logical error exception in sanitizer builds during stress tests (STID: 2508-328f). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
Contributor
|
Workflow [PR], commit [010a8bb] Summary: ✅ AI ReviewSummaryThis PR fixes ClickHouse Rules
Final Verdict
|
Tests that `IColumn::assertTypeEquality` correctly handles the case where `rhs` is a `ColumnReplicated` wrapper but `this` is a regular column. This triggers `MergingSortedAlgorithm::merge` with `ColumnReplicated` columns produced by RIGHT JOIN with `enable_lazy_columns_replication`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ity-check-both-sides
…ity-check-both-sides
…ity-check-both-sides
…ity-check-both-sides
Member
Author
|
The Stress test (arm_msan) failure is fixed by #101239, which should be merged first. After it is merged, please update the branch to include the fix. |
…ity-check-both-sides
…ity-check-both-sides
…ity-check-both-sides
…itions The test was originally added as `04066_assert_type_equality_column_replicated`, but master has since added three other tests with the same `04066` prefix. Rename to the next available prefix `04106`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ity-check-both-sides
…ity-check-both-sides
…ity-check-both-sides
…ity-check-both-sides
…ity-check-both-sides
…ity-check-both-sides
…ity-check-both-sides
…ity-check-both-sides
Contributor
LLVM Coverage ReportChanged lines: N/A (no coverable changed lines) · Uncovered code |
robot-ch-test-poll3
added
the
pr-synced-to-cloud
1 task
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assertion in
IColumn::assertTypeEqualityonly checked ifthiswas a Const/Sparse/Replicated wrapper column, but notrhs. Whenrhsis a wrapper column butthisis a regular column, the assertion incorrectly requiredtypeidequality, which fails even though the operation is valid.This caused a spurious logical error exception in sanitizer builds during stress tests (STID: 2508-328f).
Changelog category (leave one):
Version info
26.5.1.214