Add test for OR conditions in JOIN ON and IS NOT DISTINCT FROM by alexey-milovidov · Pull Request #100972 · ClickHouse/ClickHouse · GitHub
Skip to content

Add test for OR conditions in JOIN ON and IS NOT DISTINCT FROM#100972

Merged
alexey-milovidov merged 16 commits into
masterfrom
add-test-join-on-or-is-not-distinct-from
Apr 10, 2026
Merged

Add test for OR conditions in JOIN ON and IS NOT DISTINCT FROM#100972
alexey-milovidov merged 16 commits into
masterfrom
add-test-join-on-or-is-not-distinct-from

Conversation

@alexey-milovidov

@alexey-milovidov alexey-milovidov commented Mar 27, 2026

Copy link
Copy Markdown
Member

Add a test verifying that all three SQL patterns from #40976 now work correctly:

  1. OR conditions in JOIN ON clause
  2. IS NOT DISTINCT FROM in JOIN ON clause
  3. Tuple IS NOT DISTINCT FROM in JOIN ON clause

Closes #40976

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Version info

  • Merged into: 26.4.1.788

All three SQL patterns from #40976
now work correctly:
1. OR conditions in JOIN ON clause
2. IS NOT DISTINCT FROM in JOIN ON clause
3. Tuple IS NOT DISTINCT FROM in JOIN ON clause

Closes #40976

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@clickhouse-gh

clickhouse-gh Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 27, 2026
alexey-milovidov and others added 8 commits March 28, 2026 02:15
…nflict

The test uses OR conditions in JOIN ON which are only supported by the
new analyzer. Add `SET enable_analyzer = 1` so it passes in old-analyzer
CI configurations. Also rename from 04063 to 04064 to avoid conflict
with 04063_in_subquery_lowcardinality_tuple_key merged to master.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alexey-milovidov

Copy link
Copy Markdown
Member Author

The test 02859_replicated_db_name_zookeeper is fixed in #101952

@alexey-milovidov

Copy link
Copy Markdown
Member Author

@alexey-milovidov alexey-milovidov self-assigned this Apr 10, 2026

@alexey-milovidov alexey-milovidov left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, test only change.

@alexey-milovidov alexey-milovidov added this pull request to the merge queue Apr 10, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 10, 2026
@alexey-milovidov alexey-milovidov added this pull request to the merge queue Apr 10, 2026
Merged via the queue into master with commit b570fa3 Apr 10, 2026
164 checks passed
@alexey-milovidov alexey-milovidov deleted the add-test-join-on-or-is-not-distinct-from branch April 10, 2026 09:36
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid JOIN_ON condition

2 participants