{{ message }}
Fix flaky test 02916_another_move_partition_inactive_replica#100924
Merged
Conversation
The test checked specific part names after `OPTIMIZE TABLE`, but the merge selector doesn't guarantee which pairs of parts it picks. With `max_parts_to_merge_at_once=2` and 4 input parts, two `OPTIMIZE` calls always yield exactly 2 active parts, but the specific merge order varies with randomized settings. Replace the part name check with a count of active parts, which is deterministic and sufficient for the test's purpose (verifying MOVE PARTITION with inactive replicas). https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=100736&sha=f0e1f4034aebfc4eb9c70f0ead3cad620f5b8199&name_0=PR&name_1=Stateless%20tests%20%28amd_asan_ubsan%2C%20db%20disk%2C%20distributed%20plan%2C%20sequential%29 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
1 task
alexey-milovidov
left a comment
alexey-milovidov
left a comment
Member
Author
There was a problem hiding this comment.
The fix is good.
1 task
nikitamikhaylov
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test checked specific part names after
OPTIMIZE TABLE, but the merge selector doesn't guarantee which pairs of parts it picks. Withmax_parts_to_merge_at_once=2and 4 input parts, twoOPTIMIZEcalls always yield exactly 2 active parts, but the specific merge order varies with randomized settings.Replace the part name check with a count of active parts.
https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=100736&sha=f0e1f4034aebfc4eb9c70f0ead3cad620f5b8199&name_0=PR&name_1=Stateless%20tests%20%28amd_asan_ubsan%2C%20db%20disk%2C%20distributed%20plan%2C%20sequential%29
#100736
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes
Version info
26.4.1.451