{{ message }}
Fix flaky test 03800_use_const_adaptive_granularity_vertical_merge#100656
Closed
alexey-milovidov wants to merge 1 commit into
Closed
Fix flaky test 03800_use_const_adaptive_granularity_vertical_merge#100656alexey-milovidov wants to merge 1 commit into
alexey-milovidov wants to merge 1 commit into
Conversation
Use `OPTIMIZE TABLE ... FINAL` to force the merge instead of relying on merge selector heuristics. Without `FINAL`, the merge selector may decide not to merge parts (e.g., due to memory limits from `CompactionStatistics::getMaxSourcePartsBytesForMerge`), causing the test to fail because the parts remain unmerged. https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=100157&sha=6a8f4bf7d23b1337c4c93a7730b597ba68dafaff&name_0=PR&name_1=Stateless%20tests%20%28arm_binary%2C%20parallel%29 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
OPTIMIZE TABLE ... FINALto force the merge instead of relying on merge selector heuristics. WithoutFINAL, the merge selector may decide not to merge parts (e.g., due to memory limits fromCompactionStatistics::getMaxSourcePartsBytesForMerge), causing the test to fail because the parts remain unmerged.CI report: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=100157&sha=6a8f4bf7d23b1337c4c93a7730b597ba68dafaff&name_0=PR&name_1=Stateless%20tests%20%28arm_binary%2C%20parallel%29
#100157
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes