Revert "Enable server-side AST fuzzer in stress test and BuzzHouse"#100437
Revert "Enable server-side AST fuzzer in stress test and BuzzHouse"#100437alexey-milovidov wants to merge 1 commit into
Conversation
clickhouse-gh
Bot
added
the
pr-not-for-changelog
![clickhouse-gh[bot]](https://avatars.githubusercontent.com/in/928874?s=60&v=4){kind=small}
| filter_output = ActionsDAG::evaluatePartialResult( | ||
| filter_input, | ||
| { filter_node }, | ||
| { filter_dag.tryFindInOutputs(filter_column_name) }, |
There was a problem hiding this comment.
Restoring this revert drops a defensive null-check that was preventing a null ActionsDAG::Node from being passed into ActionsDAG::evaluatePartialResult.
If filter_column_name is missing from outputs, tryFindInOutputs returns nullptr, and evaluatePartialResult dereferences output nodes (e.g. node->children) without null handling. This can lead to an exception path outside the intended UNKNOWN fallback.
Please restore the guard:
const auto * filter_node = filter_dag.tryFindInOutputs(filter_column_name);
if (!filter_node)
return FilterResult::UNKNOWN;and pass { filter_node } to evaluatePartialResult.
| filter_output = ActionsDAG::evaluatePartialResult( | ||
| combined_dag_input, | ||
| { filter_node }, | ||
| { combined_dag.tryFindInOutputs(filter_column_name) }, |
There was a problem hiding this comment.
Same issue as in filterResultForNotMatchedRows: this revert removes the null-check for combined_dag.tryFindInOutputs(filter_column_name).
Without the guard, a missing output can propagate nullptr to ActionsDAG::evaluatePartialResult, which assumes valid node pointers. Please restore the previous filter_node null-check and return FilterResult::UNKNOWN when not found.
Set `ast_fuzzer_runs` back to 0 (default) in stress test and BuzzHouse CI configs while stability issues are being addressed. See #100437 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 participant
Reverts #98138
Way too powerful for now - let's enable again this week.