api.clever.com and new SSL certs by mohit · Pull Request #6 · Clever/clever-python · GitHub
Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

api.clever.com and new SSL certs#6

Merged
mohit merged 3 commits into
masterfrom
clever.com
Jan 16, 2014
Merged

api.clever.com and new SSL certs#6
mohit merged 3 commits into
masterfrom
clever.com

Conversation

@mohit

@mohit mohit commented Jan 7, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@ghost ghost assigned nathanleiby Jan 7, 2014
Comment thread clever/__init__.py Outdated

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathanleiby I experimented a little with the verify option but don't think it verifies the entire CA chain.

Example: api.twitter.com, api.stripe.com or api.facebook.com will fail when verifying with our cert chain, but not api.github.com

requests.get('https://api.github.com', verify='path-to-our-cert-bundle')

returns a 200

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting- is this a new issue with clever.com_ca_bundle.crt or the same behavior as before?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not a issue with the new ca_bundle as far as I see. And the behavior does not seem very dangerous to me, since the only way to have a website be verified is to use the same CA (DigiCert High Assurance EV) as we use.

I'll experiment some more going forward and should add a comment in the code.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathanleiby

Copy link
Copy Markdown
Contributor

The non-cert changes all look fine.

@nathanleiby

Copy link
Copy Markdown
Contributor

mohit added a commit that referenced this pull request Jan 16, 2014
api.clever.com and new SSL certs
@mohit mohit merged commit 76c7647 into master Jan 16, 2014
@mohit mohit deleted the clever.com branch January 16, 2014 02:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants