Put to patch api change#5
Conversation
ghost
assigned
There was a problem hiding this comment.
why is this called get_method?
There was a problem hiding this comment.
This existed before my changes. But looks like it is a known practice with urllib2, despite the non-ideal interface that you're setting a value through something called get_method. See: http://stackoverflow.com/a/111988/950683 and http://stackoverflow.com/a/4511785/950683
|
tests? |
There was a problem hiding this comment.
are there still PUTs being used in this library?
There was a problem hiding this comment.
No more PUTs are in use. I'll remove 'put' since it's not a possible code path.
|
@m0hit regarding tests, afaik we cannot do updates calls against the API with |
|
@nathanleiby you could just use a fake app that you created and share some demo data with it for the tests. Let's make this a code smell or something to come back to. |
|
@m0hit added a code smell in JIRA |
|
@m0hit I think this is good to merge - ok from your end? |
|
👍— On Thu, Jan 9, 2014 at 11:37 AM, Nathan Leiby notifications@github.com
|
|
Could also test put with something like nock. I'm sure there's a python equivalent (requests might even do it?) |
|
@azylman - good point. I've updated the code smell and will return to this one later. |
|
It's called responses |
4 participants
All of the PUT endpoints in our API currently behave as PATCH endpoints. We're changing the method to actually be PATCH.