{{ message }}
Repository navigation
feat!: change vendor extension tag to 'V' - #22
Merged
Merged
Conversation
Implements tc39/ecma426#278. The spec now reserves the 'V' tag (0x15) for vendor extension items instead of '/'. '/' has the VLQ continuation bit set and can't be used as a single character tag. Note that the previous Tag.VENDOR_EXTENSION value 0x63 didn't match '/' either (it encodes as "jD"). Also expands test coverage for vendor extensions: interspersed with known scope and range items in strict mode, multi-character and out-of-bounds name indices, and rejection of the legacy tags.
OrKoN
approved these changes
Oct 13, 2026
OrKoN
left a comment
OrKoN
left a comment
There was a problem hiding this comment.
The new ignores out-of-bounds name indices in strict mode test cements that STRICT mode never validates the vendor-extension name index, even though the spec defines it as an index into names. Worth deciding explicitly whether STRICT should route it through #resolveName (consistent with other indices) or stay lenient with a comment.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements tc39/ecma426#278. The spec now reserves the 'V' tag (0x15) for vendor extension items instead of '/'. '/' has the VLQ continuation bit set and can't be used as a single character tag.
Note that the previous Tag.VENDOR_EXTENSION value 0x63 didn't match '/' either (it encodes as "jD").
Also expands test coverage for vendor extensions: interspersed with known scope and range items in strict mode, multi-character and out-of-bounds name indices, and rejection of the legacy tags.