{{ message }}
Repository navigation
Tags: ChromeDevTools/devtools-frontend
Tags
Update DevTools DEPS (trusted) Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/e1a84d7..0260952 Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3e9862a..1eb46f8 Rolling third_party/inspector_protocol: https://chromium.googlesource.com/deps/inspector_protocol/+log/b814180..3f95e5a Roll created at https://cr-buildbucket.appspot.com/build/8667367125684428209 Bug: none Change-Id: Id1894b15bc6e1c807c60d33a963da8264c75e6fe Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8613841 Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
AI: Log skill, tool, error, and per-turn query VE telemetry in V2 In AI Architecture V2, all requests share a single AIDA ClientFeature (CHROME_DEVTOOLS_V2_AGENT), and most tools are DataTools that do not trigger context-change events. Without client-side telemetry for skill loading, tool calls, error types, and per-turn active context, analyzing topic popularity and per-domain error rates requires reconstructing conversation state across turns. Emit four Visual Elements FunctionCall events in AiAssistancePanel when devToolsAiV2Architecture is enabled: - ai-v2-query-submitted with the active context type on every turn. - ai-v2-learn-skill for each newly activated skill on learnSkills calls. - ai-v2-tool-call with the kebab-case tool name for DataTool and ContextTool executions on live conversations. - ai-v2-error with the ErrorType on non-abort errors. Fixed: 546084105 Change-Id: I0c166e7535a2041fea1f9183e70f74f918ba67f0 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8578558 Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Revert "[elements] Respect @layer and origin priority for !important … …declarations" This reverts commit 4f12966. Reason for revert: Incorrect solution. Original change's description: > [elements] Respect @layer and origin priority for !important declarations > > In NodeCascade.updatePropertyState(), when comparing two !important > declarations, CSS Cascade 5 reverses the priority of cascade origins > (User-Agent > User > Author), shadow tree scopes (inner scope > outer > scope), and cascade layers (earlier @layer > later @layer > unlayered). > > Previously, NodeCascade.updatePropertyState() only checked whether an > existing active property was !important while the incoming property was > not, allowing later @layer or unlayered !important declarations to > incorrectly mark earlier @layer !important declarations as overloaded. > > Fixed: 40225557 > TAG=agy > CONV=206f9566-ddcd-4264-853e-52b2ea631e5a > Change-Id: I4ec70c24cb0115ff4918cd304b80a2c5b41191ae > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8549700 > Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> > Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Bug: 40225557 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic73b49b53d8badedd56b61c83d2a23f880762531 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8578577 Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
[Lantern] Credit consumed H2 overflow bytes on intermediate steps When simulating an H2 download with h2OverflowBytesDownloaded > 0, TCPConnection.simulateDownloadUntil subtracts h2OverflowBytesDownloaded from bytesToDownload and returns only the newly downloaded bytes in calculation.bytesDownloaded. When another node (such as a parallel CPUNode) finished mid-download: 1. Simulator.updateProgressMadeInTimePeriod updated connection.h2OverflowBytesDownloaded to calculation.extraBytesDownloaded without adding the consumed overflow bytes to timingData.bytesDownloaded, causing those bytes to be downloaded a second time on subsequent steps. 2. On an unwarmed H2 connection, TCPConnection.simulateDownloadUntil only applied h2OverflowBytesDownloaded when this.warmed was true, so overflow bytes produced during an intermediate step of the initial request were wiped out on the final step before setWarmed(true). Bug: 570004155 Change-Id: I13434e8bcab14f7eace06d3ef14b0848f88fea80 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8511806 Reviewed-by: Paul Irish <paulirish@chromium.org> Commit-Queue: Connor Clark <cjamcl@chromium.org>
trace: fix event property casing, hierarchy pollution, and type misma… …tches Align DevTools TypeScript trace event interfaces (`TraceEvents.ts`) with Chromium C++ instrumentation schemas: - Fix property casing: `stylesheetUrl` -> `styleSheetUrl` [1] (ParseAuthorStyleSheet) and `websocketProtocol` -> `webSocketProtocol` [2] (WebSocketCreate). - Remove `@ts-expect-error` in `PageDependencyGraph.ts` when accessing `styleSheetUrl`. - Fix hierarchy pollution in `PaintImage` and `ScrollLayer` where `data` erroneously intersected with top-level `Event`. - Align `FunctionCall.data.scriptId` and `BeginRemoteFontLoad.args.display` types. - Decouple unneeded `ArgsData` inheritance from specific event interfaces. Also validated against hundreds of real traces. 1: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/inspector/inspector_trace_events.cc;l=1080;drc=2fd91efeb786826e83ac81c26d2c366ca3e9ab0d 2: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/websockets/inspector_websocket_events.cc;l=47;drc=9f771c84231a80894401b400f1a0d9ce34db6019 Bug: 572032867 Change-Id: I1c370ae31503b55240f0d3533e915180d8593dde Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8283064 Auto-Submit: Paul Irish <paulirish@chromium.org> Reviewed-by: Connor Clark <cjamcl@chromium.org> Commit-Queue: Connor Clark <cjamcl@chromium.org>
Roll browser-protocol and CfT This roll requires a manual review. See http://go/reviewed-rolls for guidance. Rolling CfT pin together with browser-protocol files: https://chromium.googlesource.com/chromium/src/+log/1db4836330e7da0e7bb4c9f296961f84d8d9e0d5..b6ee4b885d0553994d65ceed7fa4d86861aa517d In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8668544884272331473 R=chrome-devtools-waterfall-gardener-emea-oncall@google.com Bug: none Change-Id: Iefc98095dfab1ad3022af93d2a2c915856507dae Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8534386 Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Include file systems in Clear site data Add a File System checkbox and include the selected storage type in clearing requests. Test both checked and unchecked states. Bug: 40227285 Change-Id: I0916ba66dca3ca9a644eba7eb51e6c01aa7ac69b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8473167 Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
[settings] Migrate frame-viewer-show-paints setting to SettingDescriptor R=kimanh@chromium.org Bug: 535451658 Change-Id: I773d1a367621f9a47aa4b2a863230460f2e2067f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8523157 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
[network] Make "Copy value" match the displayed payload parameter formatParameter() replaces "+" with a space, honours the "View URL-encoded" toggle and falls back to "(unable to decode value)" when decoding fails, but the context menu handler decodes the raw value directly. Copying a parameter can therefore put different text on the clipboard than the row shows, ignores the toggle, and throws URIError on a malformed escape, leaving the clipboard untouched without any feedback. Move the decoding into a single helper used by both the view and the copy handler, and fall back to the raw value when it cannot be decoded. The rendered view is unchanged, only what "Copy value" puts on the clipboard changes. Fixed: 567556613 Change-Id: I73507d29d0dae1c54eed544a2745cec2c08a756a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8485849 Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org>
[scopes] Don't complete properties when not paused at the location When the BreakpointEditDialog is not paused at the breakpoint location, property completion substituted source-mapped variables with their generated names and evaluated them in the global scope. Generated locals like `a` then resolved to unrelated globals, and we suggested their properties as if they belonged to the authored variable. Without a call frame at the location there is nothing to evaluate local variables in. Only offer the statically known variable names in that case and skip property and Map key completion. This also removes the location-based name substitution from evaluateExpression(). Argument hints keep their behavior from before Location support: They evaluate the callee as typed. R=alexrudenko@chromium.org Fixed: 567484416 Change-Id: I55f882b1e42356881f142c95fb97a0f827d8de2f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8479933 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org>
PreviousNext
