Scope the `allowScripts` note in AGENTS.md to affected npm versions by glen-84 · Pull Request #10556 · ChilliCream/graphql-platform · GitHub
Skip to content

Scope the allowScripts note in AGENTS.md to affected npm versions - #10556

Merged
glen-84 merged 1 commit into
mainfrom
gai/scope-npm-allowscripts-note-to-versions
Oct 16, 2026
Merged

glen-84 merged 1 commit into
mainfrom
gai/scope-npm-allowscripts-note-to-versions

Conversation

@glen-84

@glen-84 glen-84 commented Oct 16, 2026

Copy link
Copy Markdown
Member

Summary

  • npm 11.21.1 and 12.2.1 fix npm install-scripts approve writing allowScripts keys that npm cannot match under install-strategy=linked (npm/cli#10059, npm/cli#9941). The note in AGENTS.md now names the versions that still need approvals added by hand.
  • The note stays for now: the website's devEngines floor is >=11.18.0, and no Node.js release bundles a fixed npm yet (Node 24.22.0 ships npm 11.19.1, Node 26.12.0 ships npm 11.20.0). It can be removed once the floor reaches 11.21.1.

Copilot AI lite review requested due to automatic review settings October 16, 2026 13:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation change is scoped and has no unresolved issues.

0 open findings

What changed in this PR

Updates AGENTS.md to scope the allowScripts workaround to affected npm versions.

Changes:

  • Applies manual approval guidance to npm 11 versions below 11.21.1 and npm 12 versions below 12.2.1.
  • Retains the workaround while older npm versions remain supported.
File Summary
AGENTS.md Narrows the npm version warning and workaround guidance.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants