{{ message }}
Cleanup config files#144
Merged
Merged
Conversation
Collaborator
Author
Collaborator
Author
|
One more fix: The |
Member
|
I think the raw torch module for BCE loss will throw an error, as we pass some kwargs to forward method which is not accepted by it. Instead the config should use the wrapper from python-chebai/chebai/loss/bce_weighted.py Lines 108 to 111 in 395b5a8 |
Collaborator
|
Looks great, thank you Simon! |
schnamo
approved these changes
Jan 26, 2026
schnamo
left a comment
Collaborator
There was a problem hiding this comment.
Everything looks good, thank you
aditya0by0
reviewed
Jan 26, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We have a lot of config files that do different things which might be confusing to new users and lead to unexpected results. For example, the callback configs sometimes save a checkpoint every 25 epochs, sometimes they only save the last checkpoint. Sometimes, they save the best 3, sometimes only the best 1.
I tried to reduce the number of configs and find a consistent naming pattern. More precisely, I
weightingsdirectory andloss/weighting_chebi100.yml- those were all static lists of weights which are not needed anymore since those weights get calculated on the fly by the weighted BCE.binary_callbacks.ymlandearly_stop_callbacks_roc-auc.ymlsolCurandtox21callbacks (as far as I can tell, they are not specific to the dataset)solves #139