Fix issue where Carthage doesn’t build for watchOS or tvOS if bitcode is disabled in Xcode 14 by daltonclaybrook · Pull Request #3293 · Carthage/Carthage · GitHub
Skip to content

Fix issue where Carthage doesn’t build for watchOS or tvOS if bitcode is disabled in Xcode 14 - #3293

Merged
giginet merged 1 commit into
Carthage:masterfrom
daltonclaybrook:dalton/xcode-14-bitcode
Nov 12, 2022
Merged

Fix issue where Carthage doesn’t build for watchOS or tvOS if bitcode is disabled in Xcode 14#3293
giginet merged 1 commit into
Carthage:masterfrom
daltonclaybrook:dalton/xcode-14-bitcode

Conversation

@daltonclaybrook

@daltonclaybrook daltonclaybrook commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

Resolves #3292

@SSheldon

SSheldon commented Aug 16, 2022

Copy link
Copy Markdown

@lukegardiner

lukegardiner commented Sep 13, 2022

Copy link
Copy Markdown

Can this get released soon now that Xcode 14 is officially out and auto-updating through the Mac App Store?

@daltonclaybrook

daltonclaybrook commented Sep 13, 2022

Copy link
Copy Markdown
Contributor Author

@tmspzz Any thoughts on merging this?

@StephanWalters

StephanWalters commented Sep 15, 2022

Copy link
Copy Markdown

@tmspzz can this be merged?

@RushanB

RushanB commented Sep 19, 2022

Copy link
Copy Markdown

Can someone merge this in?

@daltonclaybrook

daltonclaybrook commented Sep 19, 2022

Copy link
Copy Markdown
Contributor Author

@RushanB I would if I could. 😅 In the meantime, you can check out this branch and run make install.

This was referenced Sep 20, 2022
Closed
Closed
@daltonclaybrook

daltonclaybrook commented Oct 12, 2022

Copy link
Copy Markdown
Contributor Author

@jshier Hey Jon, sorry to tag you. Do you see any impediment to merging this PR?

@jshier

jshier commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

@daltonclaybrook No, but then I'm not a project maintainer here, so I have no merge privileges. Sorry.

@daltonclaybrook

daltonclaybrook commented Oct 12, 2022

Copy link
Copy Markdown
Contributor Author

@jshier Ah whoops, saw you were the author of a recently-merged commit and assumed. Sorry about that!

@maxep maxep mentioned this pull request Oct 21, 2022
Merged
1 of 6 tasks
@jvaladez

jvaladez commented Oct 26, 2022

Copy link
Copy Markdown

@erichoracek or @giginet could we get your help on this?

giginet
giginet approved these changes Oct 27, 2022
View reviewed changes

@giginet giginet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@giginet

giginet commented Oct 27, 2022

Copy link
Copy Markdown
Member

I think this PR makes sense. I'll merge this soon.

lizzydavis695
lizzydavis695 reviewed Nov 9, 2022
View reviewed changes
Comment thread Source/CarthageKit/Xcode.swift
@@ -676,6 +676,9 @@ public func buildScheme( // swiftlint:disable:this function_body_length cyclomat
sdkFilter: @escaping SDKFilterCallback = { sdks, _, _, _ in .success(sdks) }

@lizzydavis695 lizzydavis695 Aug 26, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming

@giginet
giginet merged commit a91d086 into Carthage:master Nov 12, 2022
@giginet giginet mentioned this pull request Nov 12, 2022
Closed
@daltonclaybrook
daltonclaybrook deleted the dalton/xcode-14-bitcode branch November 12, 2022 15:28
@LuisFelipe635

LuisFelipe635 commented Dec 21, 2022

Copy link
Copy Markdown

Hi guys!
When this fix will be released? I am facing big troubles to migrate an iOS project to Xcode 14 and this could help a lot

@daltonclaybrook

daltonclaybrook commented Dec 21, 2022

Copy link
Copy Markdown
Contributor Author

@LuisFelipe635 I can't comment on when it will be released, but in the meantime, you can clone the Carthage repo and run make install to build a version of Carthage with this fix.

@LuisFelipe635

LuisFelipe635 commented Dec 21, 2022

Copy link
Copy Markdown

Thanks, @daltonclaybrook, I'll try that

@gemmakbarlow

gemmakbarlow commented Jan 3, 2023

Copy link
Copy Markdown

@giginet - would you have an estimate of when this might be released ?

@giginet

giginet commented Jan 5, 2023

Copy link
Copy Markdown
Member

I'm not a core maintainer. So I haven't released Carthage, So I relied on other maintainers.
However, this project seems to be abandoned...
I'm going to try to release a newer version.

@giginet giginet mentioned this pull request Jan 15, 2023
Merged
@giginet

giginet commented Jan 28, 2023

Copy link
Copy Markdown
Member

I asked core maintainers to release a new version. However, anybody no longer exists....

I released 0.39.0 now. https://github.com/Carthage/Carthage/releases/tag/0.39.0
Sorry for waiting you.

@gemmakbarlow

gemmakbarlow commented Jan 28, 2023

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giginet giginet giginet approved these changes
+1 more reviewer
@lizzydavis695 lizzydavis695 lizzydavis695 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

In Xcode 14, Carthage does not create tvOS & watchOS builds when Bitcode is disabled