{{ message }}
util.coordinates: remove broken dist_to_coast function#840
Merged
Conversation
This was referenced Jan 17, 2024
tovogt
commented
Jan 17, 2024
peanutfun
requested changes
Feb 21, 2024
peanutfun
left a comment
peanutfun
left a comment
Member
There was a problem hiding this comment.
Nice. While removing code is great, I would like to keep the public functions and add deprecation warnings. This way, we do not habe a major change following semantic versioning. I am fine with removing utm_zones though, seems like a really obsolete function to me.
Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
tovogt
commented
Feb 21, 2024
tovogt
left a comment
tovogt
left a comment
Collaborator
Author
There was a problem hiding this comment.
I added dist_to_coast, but would still opt to remove get_coastlines since it's clearly a helper function for the distance computations.
peanutfun
reviewed
Feb 21, 2024
Fix trailing whitespace
peanutfun
approved these changes
Feb 21, 2024
Collaborator
Collaborator
Author
gdeskos
pushed a commit
to gdeskos/climada_python
that referenced
this pull request
Sep 16, 2024
…ct#840) * util.coordinates: remove dist_to_coast function * Update climada/hazard/centroids/centr.py Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com> * u_coord: dist_to_coast as wrapper for dist_to_coast_nasa * Update climada/hazard/centroids/centr.py Fix trailing whitespace * Centroids.get_dist_coast: fix tests --------- Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Centroids.set_dist_coastto avoid Persistent Wind Intensity Patterns in Historical Typhoon Tracks Beyond 180 Degrees Longitude #831 and similar issues with the implementation ofutil.coordinates.dist_to_coast(it is also quite slow, actually).util.coordinates.dist_to_coastfunction because it is now used nowhere.dist_to_coast, further reducing the amount of code inutil.coordinates.This PR fixes #831, see CLIMADA-project/climada_petals#106 for a follow-up PR in petals.
PR Author Checklist
develop)PR Reviewer Checklist