Feature/fix nightlight test by emanuel-schmid · Pull Request #718 · CLIMADA-project/climada_python · GitHub
Skip to content

Feature/fix nightlight test#718

Merged
emanuel-schmid merged 7 commits into
developfrom
feature/fix_nightlight_test
May 15, 2023
Merged

Feature/fix nightlight test#718
emanuel-schmid merged 7 commits into
developfrom
feature/fix_nightlight_test

Conversation

@emanuel-schmid

Copy link
Copy Markdown
Collaborator

Changes proposed in this PR:

This PR fixes #

PR Author Checklist

PR Reviewer Checklist

The test was failing the integration check on jenkins.
Create fake .tif.gz file, execute test, delate.tif.gz file.
@emanuel-schmid emanuel-schmid marked this pull request as draft May 10, 2023 08:04
@emanuel-schmid emanuel-schmid mentioned this pull request May 12, 2023
13 tasks
change sat_name from 'F18' to 'E99'
@NicolasColombi

Copy link
Copy Markdown
Collaborator

@emanuel-schmid

emanuel-schmid commented May 15, 2023

Copy link
Copy Markdown
Collaborator Author

Thanks a lot! 😄 I've did some minor cosmetics and added a line that deletes the **.p file in case the previous test run failed in the middle and didn't clean up after itself.

@emanuel-schmid emanuel-schmid marked this pull request as ready for review May 15, 2023 11:12
@emanuel-schmid emanuel-schmid merged commit 5234fa6 into develop May 15, 2023
@emanuel-schmid emanuel-schmid deleted the feature/fix_nightlight_test branch May 15, 2023 11:12
@NicolasColombi

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants