{{ message }}
feat(assets): Switch to pnpm and rspack#832
Open
sakshamarora1 wants to merge 2 commits into
Open
Conversation
kpsherva
reviewed
Jul 3, 2026
Contributor
There was a problem hiding this comment.
could you check this warning?
kpsherva
reviewed
Jul 3, 2026
| @@ -0,0 +1 @@ | |||
| lockfile=false No newline at end of file | |||
kpsherva
reviewed
Jul 3, 2026
| @@ -0,0 +1,12382 @@ | |||
| lockfileVersion: '9.0' | |||
Contributor
There was a problem hiding this comment.
this is quite sensitive change. If I remember correctly package-lock.json is used to build our deployment images - did you adapt that to the change, will the image still build correctly?
kpsherva
reviewed
Jul 3, 2026
Contributor
There was a problem hiding this comment.
why do we need to add package.json here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.