iframe-proxy

mscottford · 2026-04-17T20:49:27Z

Summary

Three related fixes for reading binlogs produced by the .NET 10 SDK (MSBuild 18.x):

AnalyzerManager.Analyze: replace StructuredLogger.BinLogReader with Microsoft.Build.Logging.BinaryLogReplayEventSource. The official MSBuild reader handles all 18.x event types (including AssemblyLoadBuildEventArgs), whereas BinLogReader from MSBuild.StructuredLogger may stop replaying mid-stream when it encounters unrecognised event types, leaving _evalulationResults empty so ProjectStarted falls back to null propertiesAndItems and produces no results.
EventProcessor.ProjectStarted: treat an empty e.Properties collection the same as null. BinLogReader creates ProjectStartedEventArgs with Properties set to a non-null but empty collection for binlog format 14+ events, so the existing e.Properties is null check always fell through to the old-format path, using the empty collection instead of the populated evaluation-phase results. This left ProjectReferences empty after a binlog round-trip.
AnalyzerManager obsolete string constructor: wrap the path in Path.GetFullPath() before passing it to IOPath.Parse(), restoring the behaviour of the previous NormalizePath implementation that was lost when IOPath was introduced.

Regression tests are included for the first two fixes.

Test plan

SdkProjectWithProjectReferenceGetsReferencesFromBinaryLog — builds a project with a project reference, replays the binlog, asserts ProjectReferences are populated
SdkProjectWithProjectReferenceGetsReferencesFromChildSideBinaryLog — same but using child-side /bl: logging
Existing integration test suite passes

🤖 Generated with Claude Code

…r path Three related fixes for reading binlogs produced by the .NET 10 SDK: 1. AnalyzerManager.Analyze: replace StructuredLogger.BinLogReader with Microsoft.Build.Logging.BinaryLogReplayEventSource. The official MSBuild reader handles all 18.x event types (AssemblyLoadBuildEventArgs etc.), whereas BinLogReader from MSBuild.StructuredLogger may stop replaying mid-stream when it encounters event types it does not recognise, leaving _evalulationResults empty so ProjectStarted falls back to null propertiesAndItems and produces no results. 2. EventProcessor.ProjectStarted: treat an empty e.Properties collection the same as null. BinLogReader creates ProjectStartedEventArgs with Properties set to a non-null but empty collection for binlog format 14+ events, so the existing `e.Properties is null` check always fell through to the old-format path, using the empty collection instead of the populated evaluation-phase results. 3. AnalyzerManager obsolete string constructor: wrap the path in Path.GetFullPath() before passing it to IOPath.Parse(), restoring the behaviour of the previous NormalizePath implementation that was removed when IOPath was introduced. Regression tests added for fixes 1 and 2. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Fix binlog replay with MSBuild 18.x and normalize obsolete constructor path. See Buildalyzer#329.

Corniel · 2026-04-18T07:08:38Z

@@ -83,8 +83,12 @@ private void ProjectStarted(object sender, ProjectStartedEventArgs e)
        // Make sure this is the same project, nested MSBuild tasks may have spawned additional builds of other projects
        if (AnalyzerManager.NormalizePath(e.ProjectFile) == _projectFilePath)


For readablilty, I suggest you create an file
Extensions/System.Collections.IEnumerable.cs, containing te following:

namespace System.Collections; internal static class EnumerableExtensions { extension(IEnumerable? enumerable) { public bool HasNone => enumerable?.GetEnumerator().MoveNext() is not true; } }

Than you don't need the explanation at all, als e.Proparties.HasNone, tells the story.

Note, that <LangVersion>14</LangVersion> has to be added, which is a good thing anyway.

After some consideration: Lets first merge #331 what does part the changes you want, and then follow with the rest.

Corniel · 2026-04-18T07:09:54Z

+    /// </summary>
+    [Test]
+    public void SdkProjectWithProjectReferenceGetsReferencesFromBinaryLog(
+        [ValueSource(nameof(Preferences))] EnvironmentPreference preference)


Use TestTools.Context.ForProject

Corniel

Nice improvements, and good spots! I'd like some (ecstatic) changes, but nothing to dramatic.

Copilot

Pull request overview

Fixes Buildalyzer’s binary log replay against newer MSBuild (18.x) binlogs and restores expected path normalization behavior, with integration regression tests to prevent regressions when analyzing from binlogs.

Changes:

Switch binlog replay in AnalyzerManager.Analyze to Microsoft.Build.Logging.BinaryLogReplayEventSource for MSBuild 18.x event compatibility.
In EventProcessor.ProjectStarted, fall back to evaluation-phase properties/items when ProjectStartedEventArgs.Properties is null or empty.
Normalize the obsolete AnalyzerManager(string) constructor path via Path.GetFullPath() before IOPath.Parse(), and add regression integration tests for binlog replay.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
tests/Buildalyzer.Tests/Integration/SimpleProjectsFixture.cs	Adds regression integration tests validating `ProjectReferences` survive binlog replay (host-side and child-side logging).
src/Buildalyzer/Logging/EventProcessor.cs	Treats empty `ProjectStartedEventArgs.Properties` like null to correctly use evaluation results for newer binlog formats.
src/Buildalyzer/AnalyzerManager.cs	Uses `BinaryLogReplayEventSource` for replay and restores full-path normalization in the obsolete string constructor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-18T07:16:40Z

+        string binLogPath = Path.ChangeExtension(Path.GetTempFileName(), ".binlog");
+        analyzer.AddBinaryLogger(binLogPath);


Path.GetTempFileName() creates a real temp file on disk. Using Path.ChangeExtension(...) means the original .tmp file is left behind and never deleted. Prefer generating a unique path under Path.GetTempPath() (e.g., with a GUID) to avoid leaking temp files, or delete the original temp file as well.

Copilot · 2026-04-18T07:16:40Z

+        // Given
+        StringWriter log = new StringWriter();
+        IProjectAnalyzer analyzer = GetProjectAnalyzer(@"SdkNetCore2ProjectWithReference\SdkNetCore2ProjectWithReference.csproj", log);
+        string binLogPath = Path.ChangeExtension(Path.GetTempFileName(), ".binlog");


Same temp-file issue as above: Path.GetTempFileName() creates a .tmp file that is not deleted when you switch extensions. Consider generating a .binlog path without creating the .tmp file, or ensure the original temp file is removed.

Suggested change

string binLogPath = Path.ChangeExtension(Path.GetTempFileName(), ".binlog");

string binLogPath = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName() + ".binlog");

Copilot · 2026-04-18T07:16:40Z

+            Preference = preference
+        };
+        // Child-side binary logging: the build process itself writes the binlog
+        options.Arguments.Add($"/bl:{binLogPath}");


/bl: paths containing spaces need quoting. Since EnvironmentOptions.Arguments are concatenated via string.Join(" ", ...) without automatic quoting, an unquoted temp path like C:\Users\First Last\... can make this test flaky. Consider using /bl:"{binLogPath}" (or equivalent) so MSBuild receives the full path as one argument.

Suggested change

options.Arguments.Add($"/bl:{binLogPath}");

options.Arguments.Add($"/bl:\"{binLogPath}\"");

Copilot · 2026-04-18T07:16:41Z

+        // BinaryLogReplayEventSource (from Microsoft.Build) correctly handles all MSBuild 18.x
+        // event types including AssemblyLoadBuildEventArgs. The StructuredLogger.BinLogReader
+        // stops replaying mid-stream when it encounters unknown event types in newer binlogs,
+        // causing ProjectEvaluationFinishedEventArgs to never fire and leaving _evalulationResults
+        // empty, so ProjectStarted falls back to null propertiesAndItems and no results are produced.
+        var reader = new Microsoft.Build.Logging.BinaryLogReplayEventSource();



AnalyzerManager.Analyze no longer uses MSBuild.StructuredLogger, but this file still has extern alias StructuredLogger; and using StructuredLogger::... at the top. These are now unused and can produce warnings/confusion; consider removing the alias/using (and any related package aliasing) now that replay uses Microsoft.Build.Logging.BinaryLogReplayEventSource.

mscottford added a commit to mscottford/Buildalyzer that referenced this pull request Apr 17, 2026

Merge fix/binlog-reader-and-path-normalization

d648b1b

Fix binlog replay with MSBuild 18.x and normalize obsolete constructor path. See Buildalyzer#329.

mscottford mentioned this pull request Apr 17, 2026

Update packages and add net10.0 target; drop net6.0 #330

Open

2 tasks

Corniel reviewed Apr 18, 2026

View reviewed changes

Corniel requested changes Apr 18, 2026

View reviewed changes

slang25 requested a review from Copilot April 18, 2026 07:12

Copilot started reviewing on behalf of slang25 April 18, 2026 07:13

View session

Copilot AI reviewed Apr 18, 2026

View reviewed changes

This was referenced Apr 18, 2026

Factor out PropertiesAndItems.TryCreate #331

Merged

Security vulnerability: System.Security.Cryptography.Xml v9.0.0 pulled via Microsoft.Build.Tasks.Core v18.0.2 #334

Open

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

Fix binlog replay with MSBuild 18.x and normalize obsolete constructor path - #329

Fix binlog replay with MSBuild 18.x and normalize obsolete constructor path#329
mscottford wants to merge 1 commit into
Buildalyzer:mainfrom
mscottford:fix/binlog-reader-and-path-normalization

mscottford commented Apr 17, 2026

Uh oh!

Corniel Apr 18, 2026

Uh oh!

Corniel Apr 18, 2026

Uh oh!

Corniel Apr 18, 2026

Uh oh!

Corniel left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 18, 2026

Uh oh!

Copilot AI Apr 18, 2026

Uh oh!

Copilot AI Apr 18, 2026

Uh oh!

Copilot AI Apr 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -83,8 +83,12 @@ private void ProjectStarted(object sender, ProjectStartedEventArgs e)
		// Make sure this is the same project, nested MSBuild tasks may have spawned additional builds of other projects
		if (AnalyzerManager.NormalizePath(e.ProjectFile) == _projectFilePath)

		string binLogPath = Path.ChangeExtension(Path.GetTempFileName(), ".binlog");
		analyzer.AddBinaryLogger(binLogPath);

	string binLogPath = Path.ChangeExtension(Path.GetTempFileName(), ".binlog");
	string binLogPath = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName() + ".binlog");

	options.Arguments.Add($"/bl:{binLogPath}");
	options.Arguments.Add($"/bl:\"{binLogPath}\"");

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

mscottford commented Apr 17, 2026

Summary

Test plan

Uh oh!

Corniel Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Corniel Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Corniel Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Corniel left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants