{{ message }}
Repository navigation
feat: campo logo_url no /banks/v1 (issue #834) - #886
Merged
Merged
Conversation
…rvices - CI: step de ESLint no workflow E2E (lint nunca rodava — 43 erros passaram despercebidos) - lint: mapUfToUfCode (42x prettier), weather.js, cpf (console.log redundante), cep-error-handler (disable scoped) - teste NCM: expect.assertions + comportamento real (200 [] pós-984c956) — antes passava sem validar nada - move pages/api/indices/codes.js → services/indices/codes.js (módulo de constantes virava rota 500 em produção) Co-authored-by: Hermes Agent <noreply@nousresearch.com>
Auditoria achou 26 rotas sem doc + ~10 params divergentes (doc PT-BR vs código EN, dos rebases #861-#876). Correções: - params renomeados: fipe (tipoVeiculo→vehicleType...), ibge (siglaUF→uf...), cptec (icaoCode→airport), ibpt (siglaUF→uf), solar (path→query) - paths novos: /ibge/uf/v1/regiao, /fipe/marcas/v1, /feriados/v1, /oms/cid10/v1, /status/v1 (cid10.json + status.json novos) - eleicoes.json: prefixo /api removido dos paths - holydays/statewide: path fantasma {ano}/{uf} removido (UF é query) - ibpt: ?ex=01 removido do path key (query param) - teste novo: docs-parity.test.js (paridade rotas reais ↔ doc) Co-authored-by: Hermes Agent <noreply@nousresearch.com>
Adiciona logo_url (CDN jsDelivr do projeto logos-bancos-br, do autor da issue) para bancos com logo mapeado por ISPB; null nos demais (154/469 hoje, 33%). - snapshot services/banco-central/logo-urls.json (476 ISPB→URL, gerado do pacote npm logos-bancos-br@0.6.2) - enrich em getBanksData cobre todos os caminhos (CSV/snapshot/fallback) - doc: schema Bank com logo_url opcional (string|null) - testes: logo presente, null para sem-logo, compatibilidade retroativa Co-authored-by: Hermes Agent <noreply@nousresearch.com>
13 of 37 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature #834: logo_url nos bancos
Adiciona o campo opcional
logo_urlna resposta deGET /api/banks/v1(lista e/{code}).Design
logos-bancos-br(do autor da issue) — zero infra, zero chave, URL versionada não envelheceservices/banco-central/logo-urls.json(476 ISPB→URL, do pacote npm 0.6.2) — sem chamada externa por requestenrichBanksWithLogoUrlaplicado no retorno único do service → cobre CSV do BCB, snapshot em disco e fallbackbanksListnullpara bancos sem logo (315/469 hoje, 33% de cobertura)Exemplo
{ "ispb": "00000000", "name": "BCO DO BRASIL S.A.", "code": 1, "fullName": "Banco do Brasil S.A.", "logo_url": "https://cdn.jsdelivr.net/npm/logos-bancos-br@0/logos/svg/00000000.svg" }Verificação