{{ message }}
Added a diff command to compare 2 memory dumps#56
Open
oliverde8 wants to merge 1 commit into
Open
Conversation
Author
Owner
|
Hey, thanks a lot @oliverde8 ! And sorry for the delay before the answer. I think that your diff is a great feature, very useful in the hunting memory leak process. But could you put the diff generation part in a dedicated class, like a SummaryDiffer ? This class would take two summaries and generate a diff. This would make testing much easier than having everything in the command. And by the way, if you could make the associated Spec, that would be awesome ;) Thank you! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
First thanks for this tool, it really is awesome.
I found myself comparing 2 dump on a few occasions and trying to see where I am leaking. So I thought it would be a nice feature to have in the analyzer.
Regards