Fix certificate validation for ODBC driver by Yury-Fridlyand · Pull Request #34 · Bit-Quill/opensearch-project-sql · GitHub
Skip to content

Fix certificate validation for ODBC driver#34

Merged
Yury-Fridlyand merged 1 commit into
mainfrom
odbc-fix-certificate-validation-5
Mar 9, 2022
Merged

Fix certificate validation for ODBC driver#34
Yury-Fridlyand merged 1 commit into
mainfrom
odbc-fix-certificate-validation-5

Conversation

@Yury-Fridlyand

Copy link
Copy Markdown

Description

  • Having this fix driver doesn't ignore user preferences for Hostname Verification parameter, and once it unset driver can establish SSL connection even if self-signed certificates are used
  • AWS SDK compilation workflow changed to use libcurl instead of winhttp as a transport library
    • libcurl shipped by vcpkg according to the doc
  • AWS SDK updated
  • Fixed crash in driver caused by improper libcurl resource release (incorrect order)

This PR has all changes from PRs opensearch-project#28, opensearch-project#29 and opensearch-project#30 collected all together.
Duplicate of opensearch-project#32, but with fix of DCO.

Issues Resolved

opendistro-for-elasticsearch/sql#686
opendistro-for-elasticsearch/sql#783
opensearch-project/sql-odbc#15
opensearch-project/sql-odbc#8
Applicable for ODFE too

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…pensearch-project#696 and 317 all together.

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@codecov

codecov Bot commented Mar 3, 2022

Copy link
Copy Markdown

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please add a newline to the end of any files.

@Yury-Fridlyand Yury-Fridlyand merged commit 5470b56 into main Mar 9, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the odbc-fix-certificate-validation-5 branch March 9, 2022 19:49
@Yury-Fridlyand Yury-Fridlyand restored the odbc-fix-certificate-validation-5 branch March 9, 2022 19:50
@Yury-Fridlyand Yury-Fridlyand deleted the odbc-fix-certificate-validation-5 branch June 17, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants