{{ message }}
Add team features to native-multi-image.F90 app#269
Merged
Conversation
Collaborator
Author
bonachea
requested changes
Nov 12, 2025
bonachea
left a comment
bonachea
left a comment
Member
There was a problem hiding this comment.
Thanks for this PR. The overall design looks good, I added a few requests for improvements based on a quick skim
Member
|
Rebasing to pick-up CI changes |
bonachea
force-pushed
the
update-multi-image-app
branch
from
7f5f0d2 to
b9a42b3
Compare
bonachea
requested changes
Nov 19, 2025
bonachea
left a comment
bonachea
left a comment
Member
There was a problem hiding this comment.
Recording one new observation
bonachea
force-pushed
the
update-multi-image-app
branch
from
b9a42b3 to
3c38a05
Compare
Member
bonachea
force-pushed
the
update-multi-image-app
branch
from
71e87f4 to
01b358b
Compare
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
native-multi-image test
native-multi-image.F90
with the convention for case in this test
ktras
force-pushed
the
update-multi-image-app
branch
from
aa765aa to
a51917b
Compare
bonachea
requested changes
Dec 10, 2025
bonachea
left a comment
bonachea
left a comment
Member
There was a problem hiding this comment.
A few other minor nitpicks, otherwise LGTM!
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will not pass CI (with the current macros being set for flang) until PR #165573 is merged into the llvm-project repo.