{{ message }}
Fix misleading static_assert when extra args have wrong type#1098
Merged
Conversation
When registerNodeType is called with extra constructor arguments of the wrong type, the compiler now reports that the extra arguments don't match instead of the misleading "you MUST add a constructor" message. Also remove stale script_tokenizer.cpp reference from CMakeLists.txt. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
facontidavide
force-pushed
the
fix/837-misleading-static-assert-error
branch
from
d441ef7 to
885277a
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerNodeType<T>is called with extra constructor arguments of the wrong type, the compiler now shows a helpful message ("the constructor is NOT compatible with the arguments provided") instead of the misleading "you MUST add a constructor with signature: (const std::string&, const NodeConfig&)"static_assertinto two: one for when extra args are provided (type mismatch), one for when no extra args are provided (missing constructor)script_tokenizer.cppreference from CMakeLists.txt left by the lexy removalTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit