{{ message }}
Fix #930: mock substitution hangs when TestNodeConfigs absent#1084
Merged
Conversation
Make TestNodeConfigs parsing conditional on its presence in the JSON configuration. Previously, an empty TestNodeConfigs object was always created, causing mock nodes to be registered even when no test configuration was intended, which led to infinite loops during tree execution. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
+ Coverage 66.01% 66.56% +0.54%
==========================================
Files 225 225
Lines 12750 12843 +93
Branches 1186 1196 +10
==========================================
+ Hits 8417 8549 +132
+ Misses 4283 4243 -40
- Partials 50 51 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use explicit != nullptr comparison for pointer-to-bool conversion flagged by clang-tidy. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestNodeConfigsparsing conditional on its presence in the JSON configurationTestNodeConfigsobject was always created even when absent from JSON, causing mock nodes to be registered unintentionally, leading to infinite loops during tree executionFixes #930
Test plan
🤖 Generated with Claude Code