{{ message }}
Fix #934: segfault when substituting a SubTree node#1083
Merged
Conversation
When a substitution rule replaced a SubTree with a TestNode, dynamic_cast<SubTreeNode*> returned nullptr but setSubtreeID was called unconditionally, causing a null pointer dereference. Add a null-check so setSubtreeID is only called on actual SubTree nodes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use explicit != nullptr comparisons for pointer-to-bool conversions flagged by clang-tidy. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dynamic_cast<SubTreeNode*>inXMLParser::PImpl::recursivelyCreateTreebefore callingsetSubtreeIDSubTreeNode, so the cast returns nullptr causing a segfaultFixes #934
Test plan
Substitution.SubTreeNodeSubstitutiontest that reproduces the segfault by substituting a SubTree node🤖 Generated with Claude Code