{{ message }}
Fix #937: enable returning BehaviorTreeFactory by value#1082
Merged
Conversation
Move constructor and move assignment were defaulted in the header where PImpl is an incomplete type, preventing compilation when returning BehaviorTreeFactory by value from inline functions. Move the definitions to bt_factory.cpp where PImpl is complete, matching the existing pattern used for the destructor. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1082 +/- ##
==========================================
+ Coverage 65.90% 65.92% +0.01%
==========================================
Files 225 225
Lines 12727 12739 +12
Branches 1186 1186
==========================================
+ Hits 8388 8398 +10
- Misses 4289 4291 +2
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use explicit != nullptr comparison for pointer-to-bool conversion flagged by clang-tidy. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BehaviorTreeFactorymove constructor and move assignment operator definitions from the header (= default) to the .cpp file where the PImpl type is completestd::unique_ptr<Pimpl>, enabling return-by-value from functionsFixes #937
Test plan
BehaviorTreeFactory.ReturnByValuetest that verifies factory can be returned from a function🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.