{{ message }}
Fix #1046: use-after-free when factory destroyed before tree#1081
Merged
Conversation
…ee tick After createTree(), node manifest pointers pointed into the factory's internal map. If the factory was destroyed before ticking, these became dangling pointers causing heap-use-after-free on manifest lookups. Add Tree::remapManifestPointers() which re-points each node's NodeConfig::manifest from the factory's map to the tree's own copy, called in all three createTree* methods after copying manifests. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1081 +/- ##
==========================================
+ Coverage 65.90% 65.98% +0.07%
==========================================
Files 225 225
Lines 12727 12759 +32
Branches 1186 1193 +7
==========================================
+ Hits 8388 8419 +31
Misses 4289 4289
- Partials 50 51 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use explicit != nullptr comparisons for pointer-to-bool conversions flagged by clang-tidy. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tree::remapManifestPointers()to re-point manifest pointers from the factory's internal storage to the tree's ownmanifestsmap aftercreateTree()createTreevariants (createTreeFromText,createTreeFromFile,createTree)BehaviorTreeFactoryis destroyed beforeTree::tickWhileRunning()is calledFixes #1046
Test plan
BehaviorTreeFactory.FactoryDestroyedBeforeTicktest that reproduces the use-after-free scenario🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.