{{ message }}
Fix #1029: correct left-associativity for arithmetic operators#1069
Merged
Conversation
…ipt parser The scripting engine evaluated "A - B + C" as "A - (B + C)" instead of "(A - B) + C". The root cause was that string_concat's operand chain referenced math_sum, causing it to appear twice in lexy's operation list with conflicting binding power levels. Changed string_concat::operand from math_sum to math_prefix to eliminate the duplicate entry. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+,-,*,/operators in the script parserA - B + Cwas incorrectly evaluated asA - (B + C)due to conflicting binding power levels in lexy's operation listTest plan
ScriptParser.Associativity_Issue1029Closes #1029
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.