{{ message }}
#248 Fetching spam activities with at least 0 minutes runtime (instead of only the ones longer than 1 day)#339
Draft
PLP-GTR wants to merge 3 commits intoBeWelcome:developfrom
Draft
#248 Fetching spam activities with at least 0 minutes runtime (instead of only the ones longer than 1 day)#339PLP-GTR wants to merge 3 commits intoBeWelcome:developfrom
PLP-GTR wants to merge 3 commits intoBeWelcome:developfrom
Conversation
PLP-GTR
changed the title
Contributor
Contributor
|
@PLP-GTR Regarding the heads up: In the dev environment most of the times newly introduced classes are found automatically. In the few cases that doesn't help you need to call php bin/console cache:clear. (Which is also needed to create the cache on production.) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heads up: I don't know if auto loader for has to be rebuild manually or the new class in
src/Doctrine/Functions/TimestampDiff.phpis automatically found.I have changed the filter for the admin/spam activities (production link):
from
to
Result:
When writing
App\Doctrine\Functions\TimestampDiffI tried to stick to the instructions here:→ https://www.doctrine-project.org/projects/doctrine-orm/en/2.17/cookbook/dql-user-defined-functions.html
The seemingly simpler approach to use
DATEDIFF(a.ends, a.starts) >= 0would have lead to the issue, that activities with an end time prior to the start time on the same day would show up. Although this shouldn't be possible at storage logic already, the "> 1" filter was preventing those from showing up, so I kept this logic.Fixes #248