support m4a file extension by VICrazy · Pull Request #358 · Baseflow/flutter_cache_manager · GitHub
Skip to content

support m4a file extension#358

Merged
renefloor merged 4 commits into
Baseflow:developfrom
VICrazy:develop
Dec 30, 2021
Merged

support m4a file extension#358
renefloor merged 4 commits into
Baseflow:developfrom
VICrazy:develop

Conversation

@VICrazy

@VICrazy VICrazy commented Dec 29, 2021

Copy link
Copy Markdown
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

feature

⤵️ What is the current behavior?

The m4a audio file extension is not supported now.

🆕 What is the new behavior (if this is a feature change)?

The m4a audio file extension are already supported.

💥 Does this PR introduce a breaking change?

no

🐛 Recommendations for testing

Download the m4a audio file via http, and then play the file

📝 Links to relevant issues/docs

https://github.com/Baseflow/flutter_cache_manager/pull/172/files

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

Comment thread flutter_cache_manager/lib/src/web/mime_converter.dart
@codecov

codecov Bot commented Dec 29, 2021

Copy link
Copy Markdown

VICrazy and others added 2 commits December 29, 2021 17:02
support m4a file extension

Co-authored-by: Rene Floor <r.floor.1@gmail.com>
@renefloor

Copy link
Copy Markdown
Contributor

Sorry about the analyzer, yours is the first PR since the new Flutter stable. If you want I can create a separate PR to fix the analyzer issues.

@VICrazy

VICrazy commented Dec 30, 2021

Copy link
Copy Markdown
Contributor Author

@renefloor renefloor enabled auto-merge December 30, 2021 12:37
@renefloor renefloor merged commit 205387b into Baseflow:develop Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants