{{ message }}
Repository navigation
Conversation
Bhuvannnn
requested review from
1sonofqiu,
Gezi-lzq and
superhx
as code owners
September 15, 2026 01:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related to #2723
Why
AutoMQ’s Kafka 3.8 merge conflict resolution in
b9bad9d29dchangedassertParseStringArrayWithNoSchemafromType.ARRAYtoType.MAP, even though both merge parents usedARRAY. The helper parses[...]lists and casts the value toList, so theMAPassertion is wrong and failsValuesTest.shouldParseStringListWithMultipleElementTypeson both JDK 17 and JDK 21.The ~131 metadata/KRaft controller failures from #2723 are out of scope.
What
Restore the one-line expectation in
ValuesTest.assertParseStringArrayWithNoSchematoType.ARRAY. ProductionValues.parseStringis unchanged and already returnsARRAYfor mixed-element lists.This is a partial correction toward #2723, not a full resolution of that issue.
How
Keep the array helper aligned with Kafka’s KAFKA-16289 behavior: mixed element types with no common schema still produce an array with a null element schema. Map helpers stay on
Type.MAP.Reviewer notes
connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java.Values.javais not in this PR.connect:api:test(metadata:S3UnitTest,core:S3UnitTest,s3stream:testonly). Please treat the local runs below as the check for this change.Fixes #2723.Test plan
./gradlew :connect:api:test --tests org.apache.kafka.connect.data.ValuesTest.shouldParseStringListWithMultipleElementTypes./gradlew --build-cache rat checkstyleMain checkstyleTest spotlessJavaCheck