{{ message }}
Support for OpenSslEngine with no finalizer#1669
Merged
Merged
Conversation
johnou
force-pushed
the
support_openssl_refcnt
branch
from
bba18cf to
2d3185a
Compare
Contributor
Author
Motivation: Support for Netty SslProvider.OPENSSL_REFCNT (OpenSSL-based implementation which does not have finalizers and instead implements ReferenceCounted). Modification: Add destroy method to SslEngineFactory to allow cleaning up reference counted SslContext. Result: Users can opt-in to a finalizer free OpenSslEngine and OpenSslContext.
johnou
force-pushed
the
support_openssl_refcnt
branch
from
2d3185a to
e6adb5e
Compare
Contributor
Author
|
As a side note I ran the ATC testsuite with |
Contributor
|
Thanks! |
Contributor
|
As a side issue, it would be nice to be able to enable from config instead of having to go with a custom SslEngineFactory. |
Contributor
Author
|
@slandelle I did consider that, however, OPENSSL_REFCNT is currently marked UnstableApi and wanted to avoid dependency issues with Netty. |
Contributor
|
Do you mean you're not sure OPENSSL_REFCNT is production ready yet and you want to experiment first? |
Contributor
Author
|
I believe it is production ready, however it is still marked "unstable" in Netty here https://github.com/netty/netty/blob/4.1/handler/src/main/java/io/netty/handler/ssl/SslProvider.java#L37 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Support for Netty SslProvider.OPENSSL_REFCNT (OpenSSL-based implementation which does not have finalizers and instead implements ReferenceCounted).
Modification:
Add destroy method to SslEngineFactory to allow cleaning up reference counted SslContext.
Result:
Users can opt-in to a finalizer free OpenSslEngine and OpenSslContext.