Added Automatic-Module-Name by doom369 · Pull Request #1664 · AsyncHttpClient/async-http-client · GitHub
Skip to content

Added Automatic-Module-Name - #1664

Merged
slandelle merged 2 commits into
AsyncHttpClient:masterfrom
doom369:auto_module_name
Sep 27, 2019
Merged

slandelle merged 2 commits into
AsyncHttpClient:masterfrom
doom369:auto_module_name

Conversation

@doom369

@doom369 doom369 commented Sep 27, 2019

Copy link
Copy Markdown
Contributor

Add Automatic-Module-Name to the manifest of builded jar and updated the maven-jar-plugin version. This is required to avoid warnings during the build of the systems that switched to the Java 9 modules.

@slandelle

slandelle commented Sep 27, 2019 •

Copy link
Copy Markdown
Contributor

@doom369

doom369 commented Sep 27, 2019

Copy link
Copy Markdown
Contributor Author

@slandelle you are right. I missed you have multiple modules.

@doom369

doom369 commented Sep 27, 2019

Copy link
Copy Markdown
Contributor Author

Pushed the fix. I can't check locally it is correct configuration right now (due to another non-related build errors).

@slandelle
slandelle merged commit f4c5bef into AsyncHttpClient:master Sep 27, 2019
@slandelle

Copy link
Copy Markdown
Contributor

Thanks!

@doom369

doom369 commented Sep 27, 2019

Copy link
Copy Markdown
Contributor Author

@slandelle slandelle added this to the 2.10.3 milestone Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants