Add URI to message of TimeoutException when timeout by Atry · Pull Request #1032 · AsyncHttpClient/async-http-client · GitHub
Skip to content

Add URI to message of TimeoutException when timeout#1032

Closed
Atry wants to merge 1 commit into
AsyncHttpClient:masterfrom
Atry:master
Closed

Add URI to message of TimeoutException when timeout#1032
Atry wants to merge 1 commit into
AsyncHttpClient:masterfrom
Atry:master

Conversation

@Atry

@Atry Atry commented Nov 9, 2015

Copy link
Copy Markdown

No description provided.

@slandelle

Copy link
Copy Markdown
Contributor

@Atry

Atry commented Dec 17, 2015

Copy link
Copy Markdown
Author

This PR is a duplicate of #1031 , for different branch.

@slandelle

Copy link
Copy Markdown
Contributor

Oh right, sorry.
So actually, I think you're right, and providing the url might prove useful, even if not sufficient for every use case (think ElasticSearch that always send a JSON body, even for GET requests).

If you agree with my suggestions, please feel free to provide a PR.

@Atry

Atry commented Dec 17, 2015

Copy link
Copy Markdown
Author

I was convinced by your design mentioned in #1031 that the users could store URL in their error handler.

@slandelle

Copy link
Copy Markdown
Contributor

@slandelle slandelle closed this Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants