{{ message }}
Repository navigation
fix: resolve double scrollbar in edit mode of conversation detail dialog - #9752
Merged
Merged
Conversation
dosubot
Bot
added
size:S
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider making the
90vhedit-mode card height configurable or tied to Vuetify breakpoints, as the fixed value may behave poorly on very small or very tall viewports. - The selector
.v-dialog > .v-overlay__content > .conversation-detail-card--editis quite specific; you may want to simplify it or rely on Vuetify classes to reduce brittleness if the dialog structure changes. - Since
.monaco-editor-containeris now flex-driven, double-check that its parent containers always participate in a flex layout in edit mode to avoid layout regressions when the dialog structure is reused or extended.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider making the `90vh` edit-mode card height configurable or tied to Vuetify breakpoints, as the fixed value may behave poorly on very small or very tall viewports.
- The selector `.v-dialog > .v-overlay__content > .conversation-detail-card--edit` is quite specific; you may want to simplify it or rely on Vuetify classes to reduce brittleness if the dialog structure changes.
- Since `.monaco-editor-container` is now flex-driven, double-check that its parent containers always participate in a flex layout in edit mode to avoid layout regressions when the dialog structure is reused or extended.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
RC-CHN
approved these changes
Aug 24, 2026
BegoniaHe
pushed a commit
to Xero-Team/AstrBot
that referenced
this pull request
Aug 24, 2026
…log (AstrBotDevs#9752) Upstream-Commit: c6a14e0 Upstream-Author: Rain-0x01_ <83620631+Rain-0x01-39@users.noreply.github.com> Upstream-PR: AstrBotDevs#9752 Sync-Disposition: adapt Fork-Adaptation: Keep the composition-based ConversationPage and app-dialog card, then lock edit-mode height so Monaco fills the remaining flex space instead of stacking a second scrollbar. Tested: cd dashboard && pnpm exec vitest run --config vitest.config.ts tests/viewDialogLayouts.vitest.ts
BegoniaHe
added a commit
to Xero-Team/AstrBot
that referenced
this pull request
Aug 24, 2026
Record adapted AstrBotDevs#9791 and AstrBotDevs#9752 through c6a14e0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications / 改动点
ConversationPage.vue — 对话详情弹窗：
90vh（.conversation-detail-card--edit，通过flex: 0 0 90vh覆盖 Vuetify 的flex: 1 1 100%，否则flex-basis会吞掉高度）.monaco-editor-container去掉固定height: 500px，改为flex: 1; min-height: 0，随弹窗剩余空间自适应伸缩v-card-text变为 flex 布局（flex: 1; min-height: 0）撑满卡片这样 Monaco 填满弹窗剩余高度，外层滚动条永不触发，滚动收敛为 Monaco 自身单层。预览模式布局不受影响。
Screenshots or Test Results / 运行截图或测试结果
本地
pnpm dev已验证：编辑模式仅剩 Monaco 已有的滚动条，窗口缩放自适应Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能，已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试，并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库，或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Fix edit-mode conversation detail layout so the Monaco editor fills the available dialog space without triggering an outer scrollbar.
Bug Fixes:
Enhancements:
Tests: