{{ message }}
fix: 在非安全上下文中为 copyMessage 添加 execCommand 备用方案#7747
Open
alonguser wants to merge 1 commit intoAstrBotDevs:masterfrom
Open
fix: 在非安全上下文中为 copyMessage 添加 execCommand 备用方案#7747alonguser wants to merge 1 commit intoAstrBotDevs:masterfrom
alonguser wants to merge 1 commit intoAstrBotDevs:masterfrom
Conversation
在非安全上下文中（例如通过 HTTP 局域网 IP 访问），navigator.clipboard 不可用。为此，我们添加了使用 document.execCommand(‘copy’) 的备用方案，这与 ReadmeDialog.vue 和 Settings.vue 中的现有实现保持一致。
dosubot
Bot
added
size:S
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a fallback mechanism for copying text to the clipboard using a hidden textarea when the Clipboard API is unavailable or the context is insecure. Feedback suggests making the fallback implementation more robust by using fixed positioning and read-only attributes, refactoring it into a shared utility to eliminate code duplication, and adding error handling to the primary Clipboard API call to ensure the fallback is triggered upon failure.
Comment on lines
+449
to
+461
Contributor
There was a problem hiding this comment.
建议优化 tryFallbackCopy 的实现并考虑将其提取为公共工具函数。设置 readOnly 可以防止在移动设备上弹出虚拟键盘，使用 position: fixed 并将其移出可视区域比 position: absolute 更稳健，能有效避免页面滚动或布局抖动。此外，PR 描述提到此逻辑在 ReadmeDialog.vue 和 Settings.vue 中也有重复，建议根据通用规则将其重构为共享函数以提高可维护性。
function tryFallbackCopy(text: string) {
const textArea = document.createElement("textarea");
textArea.value = text;
textArea.readOnly = true;
Object.assign(textArea.style, {
position: "fixed",
left: "-9999px",
top: "0",
});
document.body.appendChild(textArea);
textArea.select();
try {
document.execCommand("copy");
} catch (err) {
console.error("Fallback copy failed:", err);
} finally {
document.body.removeChild(textArea);
}
}
References
- 当在不同场景下实现类似功能时，应将逻辑重构为共享的辅助函数以避免代码重复。
Comment on lines
+466
to
+470
| if (navigator.clipboard && window.isSecureContext) { | ||
| await navigator.clipboard.writeText(text); | ||
| } else { | ||
| tryFallbackCopy(text); | ||
| } |
Contributor
There was a problem hiding this comment.
即使在安全上下文中，navigator.clipboard.writeText 也可能因为用户拒绝权限或其他运行时错误而失败。建议增加错误处理，确保在 Clipboard API 抛出异常时也能回退到 tryFallbackCopy。
if (navigator.clipboard && window.isSecureContext) {
try {
await navigator.clipboard.writeText(text);
return;
} catch (err) {
console.warn("Clipboard API failed, falling back:", err);
}
}
tryFallbackCopy(text);
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
tryFallbackCopyimplementation duplicates the existing clipboard fallback logic used inReadmeDialog.vueandSettings.vue; consider extracting a shared utility to avoid divergence between implementations. document.execCommand('copy')is deprecated and can fail silently; it may be worth wrappingtryFallbackCopyin a try/catch and optionally checking the boolean return value so the caller can handle failures more gracefully.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `tryFallbackCopy` implementation duplicates the existing clipboard fallback logic used in `ReadmeDialog.vue` and `Settings.vue`; consider extracting a shared utility to avoid divergence between implementations.
- `document.execCommand('copy')` is deprecated and can fail silently; it may be worth wrapping `tryFallbackCopy` in a try/catch and optionally checking the boolean return value so the caller can handle failures more gracefully.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
在非安全上下文中（例如通过 HTTP 局域网 IP 访问），navigator.clipboard 不可用。为此，我们添加了使用 document.execCommand(‘copy’) 的备用方案，这与 ReadmeDialog.vue 和 Settings.vue 中的现有实现保持一致。
Fixes #7739
Modifications / 改动点
Screenshots or Test Results / 运行截图或测试结果
由于代码运行在 Docker 容器内，无法直接修改编译后的文件进行测试。
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能，已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试，并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库，或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Bug Fixes: