{{ message }}
Repository navigation
fix(computer-tools): point permission-denied hints at the Capabilities tab - #10445
Merged
Merged
Conversation
…s tab The Agent Computer Use settings moved from 'Config -> Normal Config -> AI -> Agent Computer Use' to 'Config -> AI -> Capabilities -> Agent Computer Use'. Update the three permission-denied messages returned to the model/user so the remediation path matches the current WebUI navigation, consistent with the existing docs.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="astrbot/core/tools/computer_tools/util.py" line_range="197" />
<code_context>
"Local permission policy for this user role. Enable Local computer "
"access and `Execute code` "
- "for this role in AstrBot WebUI -> Config -> Normal Config -> AI -> "
+ "for this role in AstrBot WebUI -> Config -> AI -> Capabilities -> "
"Agent Computer Use -> Local Permission Policies."
)
</code_context>
<issue_to_address>
**Permission tests fail**
When the permission test suite runs, `check_local_execution_permission` returns the updated Capabilities path, but `test_local_permission_policy_denies_disabled_execution` still asserts that the error contains `WebUI -> Config -> Normal Config`, so pytest fails.
Update the test assertion to expect the Capabilities path.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: astrbot/core/tools/computer_tools/util.py:197
Contributor
There was a problem hiding this comment.
🔴 Critical · Permission tests fail
When the permission test suite runs, check_local_execution_permission returns the updated Capabilities path, but test_local_permission_policy_denies_disabled_execution still asserts that the error contains WebUI -> Config -> Normal Config, so pytest fails.
Update the test assertion to expect the Capabilities path.
Prompt for AI agents
In `astrbot/core/tools/computer_tools/util.py` at line 197:
**Permission tests fail**
When the permission test suite runs, `check_local_execution_permission` returns the updated Capabilities path, but `test_local_permission_policy_denies_disabled_execution` still asserts that the error contains `WebUI -> Config -> Normal Config`, so pytest fails.
Update the test assertion to expect the Capabilities path.
1 task done
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Agent Computer Use settings moved in the WebUI from
Config -> Normal Config -> AI -> Agent Computer UsetoConfig -> AI -> Capabilities -> Agent Computer Use. The permission-denied messages inastrbot/core/tools/computer_tools/util.pystill referenced the old path, sending users to a navigation entry that no longer exists.This PR updates the three affected messages so the remediation path matches the current WebUI navigation, consistent with the existing docs (
docs/en/use/computer.md,docs/en/faq.md,docs/en/use/astrbot-agent-sandbox.md):... -> Capabilities -> Agent Computer Use -> Local Permission Policies... -> Capabilities -> Agent Computer Use -> Local Permission Policies... -> Capabilities -> Agent Computer Use -> Computer Use RuntimeTest plan
ruff format/ruff checkpassSummary by Sourcery
Bug Fixes: