fix(dashboard): address desktop chrome follow-up regressions by Soulter · Pull Request #10256 · AstrBotDevs/AstrBot · GitHub
Skip to content

fix(dashboard): address desktop chrome follow-up regressions - #10256

Merged
Soulter merged 1 commit into
masterfrom
codex/desktop-macos-window-chrome-followups
Sep 27, 2026
Merged

Soulter merged 1 commit into
masterfrom
codex/desktop-macos-window-chrome-followups

Conversation

@Soulter

@Soulter Soulter commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

Summary

Follow-up fixes for the merged desktop window chrome redesign in #10227.

  • Reset the shared mobile drawer state on every route transition.
  • Keep the provider/model selector hidden when the selected agent configuration does not support it.
  • Add the missing Japanese and Russian navigation translations.
  • Scope rail tooltip shadow removal to rail tooltips only.
  • Avoid false missing-translation warnings when config metadata falls back to config translations.

Verification

  • pnpm --dir dashboard exec vue-tsc --noEmit
  • pnpm --dir dashboard build
  • git diff --check

Summary by Sourcery

Resolve desktop window chrome follow-up regressions across navigation state, selector visibility, localization, and rail tooltip styling.

Bug Fixes:

  • Reset temporary mobile drawer state on route changes.
  • Hide the provider/model selector when unavailable for the selected agent configuration.
  • Add Japanese and Russian navigation translations.
  • Prevent false missing-translation warnings for configuration metadata fallbacks.
  • Restrict shadow removal to rail tooltips.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@Soulter
Soulter merged commit bc9824d into master Sep 27, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant