fix: use selected model in webchat side threads by Soulter · Pull Request #10065 · AstrBotDevs/AstrBot · GitHub
Skip to content

fix: use selected model in webchat side threads - #10065

Merged
Soulter merged 1 commit into
masterfrom
codex/fix-thread-model-selection
Sep 13, 2026
Merged

Soulter merged 1 commit into
masterfrom
codex/fix-thread-model-selection

Conversation

@Soulter

@Soulter Soulter commented Sep 13, 2026 •

Copy link
Copy Markdown
Member

WebChat side threads omitted selected_provider and selected_model from their requests, so replies used the backend default even when a different model was selected in the main chat.

Modifications

Pass the existing provider-selection getter to ThreadPanel and read it for every send. Side threads now use the main composer's current provider and model, including changes made after opening the panel.

  • This is not a breaking change.

Verification Steps and Test Results

  • pnpm typecheck passed.
  • Executed the component's send() function with a mocked transport: verified the selected provider/model, a changed selection on the next send, and empty selections preserving backend defaults. All three checks passed.
  • ruff format . and ruff check . passed.
  • git diff --check passed.

Checklist

  • Changes have been verified as described above.
  • No new dependencies are introduced.
  • Changes do not introduce malicious code.

Summary by Sourcery

Bug Fixes:

  • Ensure WebChat side-thread replies use the provider and model currently selected in the main chat instead of falling back to backend defaults.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Soulter, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 22 hours and 24 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

@Soulter
Soulter merged commit 4007d64 into master Sep 13, 2026
24 checks passed
@Soulter
Soulter deleted the codex/fix-thread-model-selection branch September 13, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant