{{ message }}
Repository navigation
fix: use selected model in webchat side threads - #10065
Merged
Merged
Conversation
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WebChat side threads omitted
selected_providerandselected_modelfrom their requests, so replies used the backend default even when a different model was selected in the main chat.Modifications
Pass the existing provider-selection getter to
ThreadPaneland read it for every send. Side threads now use the main composer's current provider and model, including changes made after opening the panel.Verification Steps and Test Results
pnpm typecheckpassed.send()function with a mocked transport: verified the selected provider/model, a changed selection on the next send, and empty selections preserving backend defaults. All three checks passed.ruff format .andruff check .passed.git diff --checkpassed.Checklist
Summary by Sourcery
Bug Fixes: