{{ message }}
Repository navigation
Conversation
MaxGraey
marked this pull request as ready for review
June 25, 2022 09:01
Member
Member
Author
|
abs, floor, ceil, round etc will be work properly with integers even in JSMath due to |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In this PR we're doing several breaking changes:
std/util/mathNativeMath#scalebnNativeMath#remNativeMath#mod(but not tests)NativeMathfcompletelyMath.random(forf64type)Caveats:
Before this PR this will create unnecessary cast to f64,
Math.floorand downcast toi32. With this PR this code now equivalent tox / ywithout all this unnecessary work due toMath.floor,Math.truncand etc accept integers and pass through it "as is".This is the most painful caveat, which can lead to many breaking changes in some code.
Perhaps we could add new generic builtin helper which forces parameter type to float. Something like:
Thoughts?