romdotdog · Jul 20, 2021 · Jul 20, 2021 · Jul 26, 2021 · Jul 26, 2021 · Jul 26, 2021
diff --git a/.eslintignore b/.eslintignore
@@ -8,3 +8,6 @@ tests/parser/
 
 # FIXME: Tagged template literal tests with invalid escapes
 tests/compiler/templateliteral.ts
+
+# Empty array destructures
+tests/compiler/array-destructuring.ts
diff --git a/src/ast.ts b/src/ast.ts
@@ -722,7 +722,7 @@ export abstract class Node {
   }
 
   static createVariableDeclaration(
-    name: IdentifierExpression,
+    name: Expression,
     decorators: DecoratorNode[] | null,
     flags: CommonFlags,
     type: TypeNode | null,
@@ -1684,7 +1684,7 @@ export abstract class DeclarationStatement extends Statement {
     /** Declaration node kind. */
     kind: NodeKind,
     /** Simple name being declared. */
-    public name: IdentifierExpression,
+    private _name: Expression,
     /** Array of decorators, if any. */
     public decorators: DecoratorNode[] | null,
     /** Common flags indicating specific traits. */
@@ -1701,6 +1701,17 @@ export abstract class DeclarationStatement extends Statement {
   isAny(flag: CommonFlags): bool { return (this.flags & flag) != 0; }
   /** Sets a specific flag or flags. */
   set(flag: CommonFlags): void { this.flags |= flag; }
+
+  /** Attempts to return the name as an identifier. */
+  get identifierNode(): IdentifierExpression {
+    assert(this._name.kind == NodeKind.IDENTIFIER || this._name.kind == NodeKind.CONSTRUCTOR);
+    return this._name as IdentifierExpression;
+  }
+
+  /** Returns the name without any type assertions.  */
+  get name(): Expression {
+    return this._name;
+  }
 }
 
 /** Represents an index signature. */
@@ -1725,7 +1736,7 @@ export abstract class VariableLikeDeclarationStatement extends DeclarationStatem
     /** Variable-like declaration node kind. */
     kind: NodeKind,
     /** Simple name being declared. */
-    name: IdentifierExpression,
+    name: Expression,
     /** Array of decorators, if any. */
     decorators: DecoratorNode[] | null,
     /** Common flags indicating specific traits. */
@@ -1769,7 +1780,7 @@ export class BreakStatement extends Statement {
 export class ClassDeclaration extends DeclarationStatement {
   constructor(
     /** Simple name being declared. */
-    name: IdentifierExpression,
+    name: Expression,
     /** Array of decorators, if any. */
     decorators: DecoratorNode[] | null,
     /** Common flags indicating specific traits. */
@@ -1795,6 +1806,10 @@ export class ClassDeclaration extends DeclarationStatement {
     var typeParameters = this.typeParameters;
     return typeParameters != null && typeParameters.length > 0;
   }
+
+  get name(): IdentifierExpression {
+    return this.identifierNode;
+  }
 }
 
 /** Represents a `continue` statement. */
@@ -1837,7 +1852,7 @@ export class EmptyStatement extends Statement {
 export class EnumDeclaration extends DeclarationStatement {
   constructor(
     /** Simple name being declared. */
-    name: IdentifierExpression,
+    name: Expression,
     /** Array of decorators, if any. */
     decorators: DecoratorNode[] | null,
     /** Common flags indicating specific traits. */
@@ -1849,13 +1864,17 @@ export class EnumDeclaration extends DeclarationStatement {
   ) {
     super(NodeKind.ENUMDECLARATION, name, decorators, flags, range);
   }
+
+  get name(): IdentifierExpression {
+    return this.identifierNode;
+  }
 }
 
 /** Represents a value of an `enum` declaration. */
 export class EnumValueDeclaration extends VariableLikeDeclarationStatement {
   constructor(
     /** Simple name being declared. */
-    name: IdentifierExpression,
+    name: Expression,
     /** Common flags indicating specific traits. */
     flags: CommonFlags,
     /** Initializer expression, if any. */
@@ -1865,6 +1884,10 @@ export class EnumValueDeclaration extends VariableLikeDeclarationStatement {
   ) {
     super(NodeKind.ENUMVALUEDECLARATION, name, null, flags, null, initializer, range);
   }
+
+  get name(): IdentifierExpression {
+    return this.identifierNode;
+  }
 }
 
 /** Represents an `export import` statement of an interface. */
@@ -1951,7 +1974,7 @@ export class ExpressionStatement extends Statement {
 export class FieldDeclaration extends VariableLikeDeclarationStatement {
   constructor(
     /** Simple name being declared. */
-    name: IdentifierExpression,
+    name: Expression,
     /** Array of decorators, if any. */
     decorators: DecoratorNode[] | null,
     /** Common flags indicating specific traits. */
@@ -1967,6 +1990,10 @@ export class FieldDeclaration extends VariableLikeDeclarationStatement {
   ) {
     super(NodeKind.FIELDDECLARATION, name, decorators, flags, type, initializer, range);
   }
+
+  get name(): IdentifierExpression {
+    return this.identifierNode;
+  }
 }
 
 /** Represents a `for` statement. */
@@ -2017,7 +2044,7 @@ export const enum ArrowKind {
 export class FunctionDeclaration extends DeclarationStatement {
   constructor(
     /** Simple name being declared. */
-    name: IdentifierExpression,
+    name: Expression,
     /** Array of decorators, if any. */
     decorators: DecoratorNode[] | null,
     /** Common flags indicating specific traits. */
@@ -2055,6 +2082,10 @@ export class FunctionDeclaration extends DeclarationStatement {
       this.range
     );
   }
+
+  get name(): IdentifierExpression {
+    return this.identifierNode;
+  }
 }
 
 /** Represents an `if` statement. */
@@ -2077,14 +2108,18 @@ export class IfStatement extends Statement {
 export class ImportDeclaration extends DeclarationStatement {
   constructor(
     /** Simple name being declared. */
-    name: IdentifierExpression,
+    name: Expression,
     /** Identifier being imported. */
     public foreignName: IdentifierExpression,
     /** Source range. */
     range: Range
   ) {
     super(NodeKind.IMPORTDECLARATION, name, null, CommonFlags.NONE, range);
   }
+
+  get name(): IdentifierExpression {
+    return this.identifierNode;
+  }
 }
 
 /** Represents an `import` statement. */
@@ -2117,7 +2152,7 @@ export class ImportStatement extends Statement {
 export class InterfaceDeclaration extends ClassDeclaration {
   constructor(
     /** Simple name being declared. */
-    name: IdentifierExpression,
+    name: Expression,
     /** Array of decorators, if any. */
     decorators: DecoratorNode[] | null,
     /** Common flags indicating specific traits. */
@@ -2136,13 +2171,17 @@ export class InterfaceDeclaration extends ClassDeclaration {
     super(name, decorators, flags, typeParameters, extendsType, implementsTypes, members, range);
     this.kind = NodeKind.INTERFACEDECLARATION;
   }
+
+  get name(): IdentifierExpression {
+    return this.identifierNode;
+  }
 }
 
 /** Represents a method declaration within a `class`. */
 export class MethodDeclaration extends FunctionDeclaration {
   constructor(
     /** Simple name being declared. */
-    name: IdentifierExpression,
+    name: Expression,
     /** Array of decorators, if any. */
     decorators: DecoratorNode[] | null,
     /** Common flags indicating specific traits. */
@@ -2159,13 +2198,17 @@ export class MethodDeclaration extends FunctionDeclaration {
     super(name, decorators, flags, typeParameters, signature, body, ArrowKind.NONE, range);
     this.kind = NodeKind.METHODDECLARATION;
   }
+
+  get name(): IdentifierExpression {
+    return this.identifierNode;
+  }
 }
 
 /** Represents a `namespace` declaration. */
 export class NamespaceDeclaration extends DeclarationStatement {
   constructor(
     /** Simple name being declared. */
-    name: IdentifierExpression,
+    name: Expression,
     /** Array of decorators, if any. */
     decorators: DecoratorNode[] | null,
     /** Common flags indicating specific traits. */
@@ -2177,6 +2220,10 @@ export class NamespaceDeclaration extends DeclarationStatement {
   ) {
     super(NodeKind.NAMESPACEDECLARATION, name, decorators, flags, range);
   }
+
+  get name(): IdentifierExpression {
+    return this.identifierNode;
+  }
 }
 
 /** Represents a `return` statement. */
@@ -2253,7 +2300,7 @@ export class TryStatement extends Statement {
 export class TypeDeclaration extends DeclarationStatement {
   constructor(
     /** Simple name being declared. */
-    name: IdentifierExpression,
+    name: Expression,
     /** Array of decorators, if any. */
     decorators: DecoratorNode[] | null,
     /** Common flags indicating specific traits. */
@@ -2267,13 +2314,17 @@ export class TypeDeclaration extends DeclarationStatement {
   ) {
     super(NodeKind.TYPEDECLARATION, name, decorators, flags, range);
   }
+
+  get name(): IdentifierExpression {
+    return this.identifierNode;
+  }
 }
 
 /** Represents a variable declaration part of a {@link VariableStatement}. */
 export class VariableDeclaration extends VariableLikeDeclarationStatement {
   constructor(
     /** Simple name being declared. */
-    name: IdentifierExpression,
+    name: Expression,
     /** Array of decorators, if any. */
     decorators: DecoratorNode[] | null,
     /** Common flags indicating specific traits. */