Fix segfaults during CDX read by the-blank-x · Pull Request #24 · ArchiveTeam/wget-lua · GitHub
Skip to content

Fix segfaults during CDX read - #24

Open
the-blank-x wants to merge 5 commits into
ArchiveTeam:v1.21.3-atfrom
the-blank-x:cdx-read-segfault
Open

Fix segfaults during CDX read#24
the-blank-x wants to merge 5 commits into
ArchiveTeam:v1.21.3-atfrom
the-blank-x:cdx-read-segfault

Conversation

@the-blank-x

Copy link
Copy Markdown

Fixes #23

@the-blank-x

the-blank-x commented Jan 27, 2024

Copy link
Copy Markdown
Author

@the-blank-x
the-blank-x marked this pull request as draft January 27, 2024 01:56
@the-blank-x

Copy link
Copy Markdown
Author

The invalid WARC-Refers-To-Date headers issue should be fixed now

@the-blank-x
the-blank-x marked this pull request as ready for review January 29, 2024 00:57
@Arkiver2

Arkiver2 commented Jan 29, 2024

Copy link
Copy Markdown
Member

Thank you! It looks like warc_date = cdx_to_warc_timestamp(date); is not xfreed after use.

I will need to check this PR closer before merging it.

@the-blank-x

Copy link
Copy Markdown
Author

If this is not done, wget segfaults if --warc-dedup is not passed (but
--warc-file and --warc-cdx is)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segmentation fault (null pointer read and/or write) when reading CDX files

2 participants