{{ message }}
Fix segfaults during CDX read - #24
Open
the-blank-x wants to merge 5 commits into
Open
Conversation
Author
the-blank-x
marked this pull request as draft
January 27, 2024 01:56
the-blank-x
force-pushed
the
cdx-read-segfault
branch
from
January 29, 2024 00:57
98d7eb6 to
463b2f6
Compare
Author
|
The invalid WARC-Refers-To-Date headers issue should be fixed now |
the-blank-x
marked this pull request as ready for review
January 29, 2024 00:57
Member
|
Thank you! It looks like I will need to check this PR closer before merging it. |
Author
If this is not done, wget segfaults if --warc-dedup is not passed (but --warc-file and --warc-cdx is)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #23