{{ message }}
fix(cms): clear governance publishing flow, remove failing publish button#1204
Open
hummusonrails wants to merge 5 commits into
Open
fix(cms): clear governance publishing flow, remove failing publish button#1204hummusonrails wants to merge 5 commits into
hummusonrails wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… pane decap 3.13 renders publish/status/save as the same StyledDropdownButton, so the publish control is discriminated by visible label rather than class. fix the banner route match to include new entries and anchor it inside the scrollable editing pane instead of a non-existent toolbar class.
the banner was injected into #nc-root before the editor mounted, where the absolutely-positioned editor covers it. anchor only to the scrollable ControlPaneContainer, wait until it exists, and re-home if misplaced so it survives decap's editor re-render.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
makes the decap cms governance publishing flow clear so non-technical writers never hit the protected-branch merge error.
why
mainis protected and requires a pull request review. decap's "publish" button tries to merge the entry's pr directly via the github api, which branch protection correctly rejects, surfacing a redAPI_ERROR: Changes must be made through a pull requestto writers. this looked broken and caused confusion.decap has no native way to couple its review step to a vcs approval gate (decaporg/decap-cms#7200), and it opens the pr automatically on first save, so the write → review → ready flow already lives in the cms. the only problem is the publish button.
what changed
all in
static/admin/index.html:no
config.ymlchange, no github actions, no cms migration. editorial workflow and native on-save pr creation are unchanged.writer flow after this
note for repo settings
enabling "automatically delete head branches" keeps merged entries from lingering in the cms "ready" column (decaporg/decap-cms#1592). this is a repo setting, intentionally not part of this pr.
verification
on a preview deploy
/admin/: confirm the publish button is gone, save/status/delete remain, the banner renders only in the editor, and marking an entry ready produces a pr with no error.