fix(ui): avatar image performance by JoltCode · Pull Request #307 · AnswerOverflow/AnswerOverflow · GitHub
Skip to content

fix(ui): avatar image performance#307

Merged
RhysSullivan merged 7 commits into
AnswerOverflow:mainfrom
JoltCode:ui-hero-image-perf
Mar 29, 2023
Merged

fix(ui): avatar image performance#307
RhysSullivan merged 7 commits into
AnswerOverflow:mainfrom
JoltCode:ui-hero-image-perf

Conversation

@JoltCode

Copy link
Copy Markdown
Collaborator

Description

Implements next/image to the avatar image

Fixes #306 (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated .env.example if I added a new environment variable
  • My PR title follows the semantic commits style

@vercel

vercel Bot commented Mar 28, 2023

Copy link
Copy Markdown

@vercel

vercel Bot commented Mar 28, 2023

Copy link
Copy Markdown

@JoltCode is attempting to deploy a commit to the AnswerOverflow Team on Vercel.

A member of the Team first needs to authorize it.

@codecov

codecov Bot commented Mar 28, 2023

Copy link
Copy Markdown

Codecov Report

Merging #307 (e1b6cb3) into main (a718e05) will increase coverage by 84.52%.
The diff coverage is n/a.

❗ Current head e1b6cb3 differs from pull request most recent head 83cd48f. Consider uploading reports for the commit 83cd48f to get more accurate results

@@            Coverage Diff            @@
##           main     #307       +/-   ##
=========================================
+ Coverage      0   84.52%   +84.52%     
=========================================
  Files         0      134      +134     
  Lines         0    11497    +11497     
  Branches      0     1531     +1531     
=========================================
+ Hits          0     9718     +9718     
- Misses        0     1523     +1523     
- Partials      0      256      +256     

see 134 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ref={ref}
asChild
className={cn('aspect-square h-full w-full ', className)}
src={src}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove src here

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe do a <> </> blank component if src is null

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont hardcode sizes, get it from the passed in size

@RhysSullivan RhysSullivan marked this pull request as ready for review March 29, 2023 17:30
@RhysSullivan RhysSullivan merged commit 8ffb3cf into AnswerOverflow:main Mar 29, 2023
@JoltCode JoltCode deleted the ui-hero-image-perf branch March 30, 2023 08:31
RhysSullivan added a commit that referenced this pull request Dec 20, 2025
* tweak(docs): design guidelines

* fix(ui/avatar): implement next/image

* lower icon sizes

* Update _document.tsx

---------

Co-authored-by: Rhys Sullivan <39114868+RhysSullivan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚛ component Issue relates to a react component 🖥️website Relates to the website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ui): avatar image performance

2 participants