{{ message }}
Migrate fill info retrieval to the new LHC plugin#772
Merged
knopers8 merged 1 commit intoAliceO2Group:masterfrom Nov 19, 2025
Merged
Migrate fill info retrieval to the new LHC plugin#772knopers8 merged 1 commit intoAliceO2Group:masterfrom
knopers8 merged 1 commit intoAliceO2Group:masterfrom
Conversation
knopers8
changed the title
This commit adds a new call in LHC plugin which updates a given environment with the latest known fill information. Once we validate it, we can proceed with switching off the bkp.RetrieveFillInfo() call. A necessary change in workflow template will have to follow. This approach is better, because we don't rely on a man in the middle, thus reduce risks of errors and getting the required info too late (i.e. not before SOR). Closes OCTRL-1057
justonedev1
approved these changes
Nov 17, 2025
Collaborator
justonedev1
left a comment
justonedev1
left a comment
There was a problem hiding this comment.
I approve this but I am not sure whether all of the global variables are set/reset correctly, but I trust you that they are.
However I have one question about timestamps. We are receiving timestamps about beam via kafka, so it means that when we reach stable beam we get new message with stable beam start and no end, right? And when the beam is dumped, we receive what exactly?
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new call in LHC plugin which updates a given environment with the latest known fill information. Once we validate it, we can proceed with switching off the bkp.RetrieveFillInfo() call. A necessary change in workflow template will have to follow.
This approach is better, because we don't rely on a man in the middle, thus reduce risks of errors and getting the required info too late (i.e. not before SOR).
Closes OCTRL-1057