Rewrite editor lists in editor-setup.md by georgerahul24 · Pull Request #46 · Akuli/python-tutorial · GitHub
Skip to content

Rewrite editor lists in editor-setup.md#46

Merged
Akuli merged 27 commits into
Akuli:masterfrom
georgerahul24:master
Dec 12, 2022
Merged

Rewrite editor lists in editor-setup.md#46
Akuli merged 27 commits into
Akuli:masterfrom
georgerahul24:master

Conversation

@georgerahul24

@georgerahul24 georgerahul24 commented Dec 3, 2022

Copy link
Copy Markdown
Contributor

Are these changes ok?
I had rewritten the part where it says bad editor to might not be suitable at this stage

Fixes #33

@georgerahul24 georgerahul24 changed the title Closes #33 Closes Akuli/python-tutorial#33 Dec 3, 2022
@georgerahul24 georgerahul24 changed the title Closes Akuli/python-tutorial#33 Closes Issue #33 (editor-setup.md is too opinionated) Dec 3, 2022
@Akuli

Akuli commented Dec 3, 2022

Copy link
Copy Markdown
Owner

@georgerahul24

Copy link
Copy Markdown
Contributor Author

I have divided into three parts like you had hinted..Is that fine?

@Akuli

Akuli commented Dec 6, 2022

Copy link
Copy Markdown
Owner

I like it! I will review in more detail later.

@Akuli Akuli left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said, I really like what you wrote overall :)

This is a big pile of small nits. I mostly simplified the grammar. I want the tutorial to be usable for people who aren't good at english, so I try to write in a simple way.

Comment thread basics/editor-setup.md Outdated
Comment thread basics/editor-setup.md Outdated
Comment thread basics/editor-setup.md Outdated
Comment thread basics/editor-setup.md Outdated
Comment thread basics/editor-setup.md Outdated
Comment thread basics/editor-setup.md Outdated
Comment thread basics/editor-setup.md Outdated
Comment thread basics/editor-setup.md Outdated
Comment thread basics/editor-setup.md Outdated
Comment thread basics/editor-setup.md Outdated
georgerahul24 and others added 17 commits December 8, 2022 22:12
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24

georgerahul24 commented Dec 8, 2022

Copy link
Copy Markdown
Contributor Author

As I said, I really like what you wrote overall :)

This is a big pile of small nits. I mostly simplified the grammar. I want the tutorial to be usable for people who aren't good at english, so I try to write in a simple way.

Its fine...going through the suggestions I do feel that the sentences are more complex than I expected them to be.

georgerahul24 and others added 3 commits December 8, 2022 22:21
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
georgerahul24 and others added 3 commits December 8, 2022 22:22
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@georgerahul24

Copy link
Copy Markdown
Contributor Author

I hope that I resolved all the conflicts...Incase I left somethingg out it would be great if you could bring that to my notice..

@Akuli Akuli left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last couple tweaks...

Comment thread basics/editor-setup.md Outdated
Comment thread basics/editor-setup.md Outdated
georgerahul24 and others added 2 commits December 11, 2022 16:48
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@Akuli Akuli changed the title Closes Issue #33 (editor-setup.md is too opinionated) Rewrite editor lists in editor-setup.md Dec 12, 2022
@Akuli Akuli merged commit e112702 into Akuli:master Dec 12, 2022
@Akuli

Akuli commented Dec 12, 2022

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

editor-setup.md is too opinionated

2 participants