{{ message }}
CVE-2023-40217#34
Merged
Merged
Conversation
Without this the socket timeout code fails to compile
…IOError in Python2
icanhasmath
reviewed
Jan 31, 2024
icanhasmath
reviewed
Jan 31, 2024
icanhasmath
left a comment
icanhasmath
left a comment
There was a problem hiding this comment.
Socket should be available in python2 : https://docs.python.org/2.7/library/socket.html
Author
Author
I need to look into it again, I believe that was the Enum problem I was having. |
rickprice
force-pushed
the
BE-3126-cve-2023-40217
branch
2 times, most recently
from
4eb7f15 to
5d88718
Compare
Author
rickprice
force-pushed
the
BE-3126-cve-2023-40217
branch
from
5d88718 to
d0fee9c
Compare
icanhasmath
approved these changes
Feb 7, 2024
icanhasmath
left a comment
icanhasmath
left a comment
There was a problem hiding this comment.
Looks good - Tested consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for CVE-2023-40217